feat: リトライ回数・間隔を input 化(FR-4)#51
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughSummary by CodeRabbit
Walkthrough
Changesリトライ入力とジョブサマリー
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
==========================================
+ Coverage 62.92% 63.15% +0.23%
==========================================
Files 9 10 +1
Lines 178 190 +12
Branches 51 53 +2
==========================================
+ Hits 112 120 +8
- Misses 59 63 +4
Partials 7 7
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
1 issue found across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
4f0df8f to
ae38e27
Compare
- core.summary にバージョン・アセット・取得元・cache・checksum・実行ファイルパスを表形式で記載 - cache hit 時は checksum を n/a、skip-checksum 時は skipped、通常時は verified と表示
- core.summary.write() returns a Promise; await it in the async run() function - Rephrase the comment so it does not introduce an 8th step to the fixed 7-step pipeline
- action.yml: retries / retry-base-ms input を追加(既定値 3 / 1000) - src/inputs.ts: 非負整数 input パーサーを追加。無効値時は警告して既定値に fallback - src/main.ts: 全 withRetry 呼び出しで input 値を使用 - tests/inputs.test.ts: パーサーのユニットテストを追加
- README / 要求仕様書 §6.1 の inputs 表に 2 input を追記 - TODO.md: #40 を解決済み(#51)へ移動 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AECzAv2vcdATecuvLjBSa6
ae38e27 to
5529777
Compare
概要
要求仕様書 FR-4 に対応。
retries/retry-base-msをaction.ymlの input として追加し、ネットワークリトライを調整可能にする。変更内容
action.ymlretriesinput(任意、既定値3)retry-base-msinput(任意、既定値1000)src/inputs.ts(新規)src/main.tswithRetry呼び出し(version 解決、download、checksum fetch)で input 値を使用tests/inputs.test.ts(新規)使用例
検証
pnpm run all✅参照
Summary by cubic
Make network retry behavior configurable with new
retriesandretry-base-msinputs (FR-4). Also add a job summary with install details (NFR-5) and harden CI gates to fail on cancelled or failed upstream jobs.New Features
retries(default 3) andretry-base-ms(default 1000 ms) inputs inaction.yml; applied to version resolve, download, and checksum fetch.n/aon cache hit,skippedwhen disabled, orverified (SHA256); summary write is awaited and guarded so errors don’t fail the action.Bug Fixes
pull-requests: readfordorny/paths-filter.Written for commit 5529777. Summary will update on new commits.