loadWorkbook removing formatting

[mdorchuckuva]

When using loadWorkbook, formatting that has been applied by a user in excel directly is being stripped.

With the attached excel file in my working directory, running the following code opens a file with cell C4 in black, unbolded text instead of the red, bold text as originally in the file. The formatting remains stripped if I save the wb object back out and then open from file explorer.

library(openxlsx)
wb = loadWorkbook("testopenxlsx.xlsx")
openXL(WB)

System information
Windows 10 Enterprise 10.0.19042
Have tested on R 4.0.3 and R 4.1.0, in both cases the issue persists
Openxlsx version 4.2.4
Office 365 version 2102
testopenxlsx.xlsx

[mdorchuckuva]

I found that the issue no longer occurs if I back up my openxlsx version to 4.0.0, in case that helps narrow it down.

[ycphs]

In your example is you open a different workbook than the one you loaded

library(openxlsx) 
wb = loadWorkbook("testopenxlsx.xlsx")
openXL(WB)

Please try the following:

library(openxlsx) 
wb = loadWorkbook("testopenxlsx.xlsx")
openXL(wb)

[mdorchuckuva]

Sorry the wb got capitalized when I pasted over for some reason. I was running the same workbook. see screenshot below and thanks so much for taking a look!

Top workbook is what opens from OpenXL, bottom workbook is the workbook that was originally saved.

[JanMarvin]

I've seen similar issues before. What I have found is that the style order is changed by openxlsx. We always add our default style to styles.xml, which is picked here and all the other styles are re-sorted and do no longer match with the style ids in the worksheet. Iirc the styles file has no style id field and they are picked in the order of appearance. Kinda the same issue as #81.

[Seviks]

I can confirm this issue on 4.2.4. When I loadWorkbook, do my changes (or not) an then saveWorkbook, the formatting is gone.

Formats persisted in 4.2.3. After roll back to 4.2.3 the issue is gone.

Tested on:
openxlsx 4.2.4
Windows 10
R 4.1.0
Office 2019

[patrick-gerland]

Indeed, by upgrading to version 4.2.4 this new issue happens. Rolling back to the previous version fixes the problem.
I spent most of 1 day troubleshooting what happened to all my workbooks (>200 with multiple worksheets).

Just loading and saving back the file causes the problem with loosing the existing settings for the default column headers.
wb <- loadWorkbook(input.file)
saveWorkbook(wb, input.file, overwrite = T)

The initial wb simply contains 1 worksheet like
addWorksheet(wb, sheet = "myInput")
writeDataTable(wb, sheet = "myInput", x = myInput, colNames = TRUE, rowNames = FALSE, headerStyle = hs1, tableStyle = "TableStyleLight2", withFilter = FALSE, bandedRows = TRUE)

with
hs1 <- createStyle(fgFill = "#4F81BD", halign = "CENTER", textDecoration = "Bold", border = "Bottom", fontColour = "white")

with the newer version fontColour setting gets lost to some dark default instead of white.

[derekunderwood]

Similar issue here although format is being altered, not removed entirely. Seemed appropriate to post here but please move if separate issue.

Cells formatted single accounting underline using this option:

Appear to load with normal underline formatting:

Tested on:
openxlsx 4.2.3
Windows 10
R 3.6.3
Office 2016

underline_test.xlsx

[JanMarvin]

A potential fix is in #237 could any of you test this please?

[patrick-gerland]

Thanks lot. I just installed the latest development version packageVersion("openxlsx") ‘4.2.4.9000’ Unfortunately the problem remains.

…

On Fri, Jul 30, 2021 at 11:04 AM Jan Marvin Garbuszus < ***@***.***> wrote: A potential fix is in #237 <#237> could any of you test this please? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#207 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACSJOTPDOCQ5EZNDKEPXFCDT2K5PZANCNFSM47ITCGMA> .

[mdorchuckuva]

Thanks so much @JanMarvin. Sorry for the delayed response here.

I built #237 on Windows. Results are shown in the screenshot. Left book is the input, right book is what opens from openxlsx::openXL. We keep font changes, bolding and underlines. We still lose merged cell, color changes, and strikethrough. Input workbook also attached for your reference.

Please let me know if I can do anything to help that involves R (do not know cpp, sorry).

[testopenxlsx.xlsx](https://github.com/ycphs/openxlsx/files/6941882/testopenxlsx.xlsx

[JanMarvin]

Thanks for testing (the pull request isn't yet merged with the master branch, I wanted to get feedback first).

@mdorchuckuva do you remember if these used to work with prior releases or did you list them for being important?

[mdorchuckuva]

@JanMarvin thanks!

Yes we had a report that contained some of these features (particularly merged cells) that broke after an update to openxlsx.

I can confirm the test workbook works correctly across all items except strikethrough if I roll back to 4.0.0.