Skip to content

Use Conductor Analytics card - #23

Open
cyril-sf wants to merge 1 commit into
yapplabs:masterfrom
cyril-sf:conductor_analytics
Open

cyril-sf wants to merge 1 commit into
yapplabs:masterfrom
cyril-sf:conductor_analytics

Conversation

@cyril-sf

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread vendor/conductor-analytics/card.js Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should likely define something more specific.

define("conductor/analytics/card/application") 

or something

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm. This code lives inside the iframe, so there's no risk of conflict for the moment, but I agree, this isn't a great module name.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this card might be a good test-bed for inline-adapter / pure-adapter card.

@stefanpenner

Copy link
Copy Markdown
Contributor

Awesome. I am excited. I left some inline comments.

One holistic thing i noticed, was that you build an namespace, depend on the namespace, and do lots of the stitching yourself. EAK or something like EAK would eleviate most of these concerns, and likely improve developer happiness.

If EAK is deficient in some way, let me know and we should work together to resolve that deficiency.

@stefanpenner

Copy link
Copy Markdown
Contributor

@cyril-sf got a chance to rebase ?

@cyril-sf

Copy link
Copy Markdown
Contributor Author

@stefanpenner I'm taking a look at it now

@stefanpenner

Copy link
Copy Markdown
Contributor

@cyril-sf thanks dude.

@cyril-sf

Copy link
Copy Markdown
Contributor Author

@stefanpenner I've updated the code, feel free to let me know if you have any issues with it. I didn't get the chance of using EAK yet on this project (but on another one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants