Draft
Conversation
amithad
requested changes
Apr 11, 2026
| @@ -101,7 +117,8 @@ async def run(self): | |||
| raise | |||
| except Exception as e: | |||
| self._print(f"Error: {e}") | |||
Member
There was a problem hiding this comment.
We are printing the log here anyway right?
Contributor
Author
There was a problem hiding this comment.
yes, but the user sees only the short error message and the debug log keeps the full traceback for troubleshooting.
So it is useful, but not required for normal output.
| break | ||
| response_text = "" | ||
|
|
||
| if hasattr(runner, "run_async"): |
Contributor
Author
There was a problem hiding this comment.
In our case, I kept run_async because I saw issues when it was not checked and the code broke in some setups. Some runner versions support async and some do not so this check helps the code work safely in both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes inconsistent and noisy runtime error handling across Agent Kernel runners, with a focus on issue #247.
It standardizes user-facing error messages, prevents traceback-heavy CLI output in normal usage, and stabilizes example environments (especially LangGraph) so failures are reproducible and readable.
Type of Change
Related Issues
Fixes #247
Relates to #247
Changes Made
AgentReplyTexterrors instead of bubbling raw framework exceptions.None-text reply issues.Testing
Manual checks performed:
Checklist
Screenshots (if applicable)
N/A
Additional Notes