Repository navigation
Set autocomplete="off" on the helper textarea - #6057
Merged
Merged
Conversation
Without an autocomplete hint, focusing a terminal on iOS/iPadOS Safari pops the AutoFill accessory (passwords / credit cards / contacts) for the hidden textarea. The sibling hints (autocorrect, autocapitalize, spellcheck) are already set; this adds the missing one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Tyriar
approved these changes
Aug 9, 2026
srid
added a commit
to juspay/kolu
that referenced
this pull request
Aug 9, 2026
…r, Safari autofill (#2130) Bump the terminal engine from **`@xterm/xterm@6.1.0-beta.289` / `@xterm/addon-webgl@0.20.0-beta.288`** to the latest published betas — **`6.1.0-beta.300` / `0.20.0-beta.297`**. kolu rides the 6.1 beta line via `pnpm.overrides` (stable latest is still 6.0.0). Other addons and `@xterm/headless` stay on their package ranges, same as the previous bump (#1830). ### What's new in xterm.js (since beta.289) | Upstream | What it does for tiles | | --- | --- | | [xtermjs#6043](xtermjs/xterm.js#6043) | When the **shared WebGL glyph atlas** would exceed texture capacity, it **evicts and rebuilds** instead of adding a page the renderer can't use — and bumps `pageLayoutVersion` so every live tile sharing the atlas refreshes. Follow-on to the page-layout invalidation we already took in #1830. | | [xtermjs#6055](xtermjs/xterm.js#6055) | `clearTexture()` now bumps the same layout version. Clearing the atlas on **one** tile no longer leaves **siblings painting stale glyphs** from wiped atlas pages (VS Code hit this on OS resume; multi-tile WebGL is exactly our setup). | | [xtermjs#6057](xtermjs/xterm.js#6057) | Helper textarea gets `autocomplete="off"`, so **iPadOS Safari** stops offering password / AutoFill suggestions when a terminal focuses. Desktop unchanged. | Also upstream in the range: extra WebGL atlas stress coverage for TUI-style alternate-buffer redraws (xtermjs#6056), plus dependency and docs-only noise. ### This PR - `pnpm.overrides`: xterm **289→300**, addon-webgl **288→297** (matched pair) - Refresh `fetchPnpmDeps` hash in `nix/workspace.nix` - Changelog under *Inside a Tile* naming the three user-visible upstream fixes - `@kolu/xterm-kit` contract suites green on the new pin (94/94) ### Try it locally ```sh nix run github:juspay/kolu/chore/xterm-beta-300 ``` _Generated by Grok Build (model `grok-4.5`)._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS/iPadOS Safari, focusing a terminal brings up the keyboard AutoFill accessory offering passwords / credit cards / contact info, because the hidden helper textarea carries no
autocompletehint and Safari treats it as an autofillable form field.The textarea already sets the sibling hints —
autocorrect,autocapitalize,spellcheck— so this adds the missingautocomplete="off". Verified on iPadOS Safari: the AutoFill suggestions no longer appear when the terminal gains focus. (Chrome for iOS draws its own autofill bar and ignores the hint by policy, so this helps Safari/WebKit-hinted browsers only.)No behavior change on desktop browsers.