[alxmrs]

Why

pytest 9.2.0, released 2026-10-27, raises TypeError: pytest.approx() does not support nested data structures. Seven ddxdb assertions compared a list of (key, value) pairs with approx. CI installs the newest pytest (pytest>=7), so ddxdb's wheel jobs fail on every PR, as they do on #214.

How

Each of the seven compares dict(pairs(...)) with approx of a dict instead, as the other ddxdb tests already do. Tests only.

Tests

Under pytest 9.2.0, main's ddxdb tests have 7 failures. This branch's pass (116 passed, 1 xfailed).

🤖 Generated with Claude Code

https://claude.ai/code/session_01CvszJhH8pn8H9G69wEPMU2

Summary by CodeRabbit

• Tests
  • Updated validation for gradient, Hessian-vector-product, and DuckDB query results to compare values by row ID, avoiding reliance on row ordering.
  • Existing expected values and tolerances remain unchanged.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: e659f4ae-a220-4252-bf13-37447a00bfe2

Commits

Reviewing files that changed from the base of the PR and between e543eb2 and 1aa62e2.

Files selected for processing: 2

• python/ddxdb/tests/test_ad.py
• python/ddxdb/tests/test_duckdb.py

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Walkthrough

Six test assertions now compare keyed row values as dictionaries instead of ordered lists of pairs. The expected values remain unchanged.

Changes: Test assertion updates

Layer / File(s)	Summary
Keyed result assertions python/ddxdb/tests/test_ad.py, python/ddxdb/tests/test_duckdb.py	Gradient and Hessian-vector-product tests, plus DuckDB tests, compare keyed results as dictionaries. Expected values remain unchanged.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

• xqlsystems/ddx#192: Added DuckDB shared-loss tests whose assertions this PR changes to dictionary comparisons.
• xqlsystems/ddx#200: Added the window-differentiation and documentation-example tests whose assertions this PR changes to dictionary comparisons.

Suggested labels: testing

Merge Risk: Minimal · up to 1aa62

The PR only adjusts test comparison semantics and introduces no established merge-blocking risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: updating ddxdb tests to compare rows as dictionaries with pytest.approx for pytest 9.2 compatibility.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 6 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

[alxmrs]

Lgtm