Skip to content

Feature/mips vx4#295

Merged
xalbertoisorna merged 7 commits intoxmos:vx4from
xalbertoisorna:feature/mips-vx4
Mar 19, 2026
Merged

Feature/mips vx4#295
xalbertoisorna merged 7 commits intoxmos:vx4from
xalbertoisorna:feature/mips-vx4

Conversation

@xalbertoisorna
Copy link
Contributor

No description provided.

@xalbertoisorna xalbertoisorna requested a review from Copilot March 19, 2026 09:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds VX4 (VX4B-focused) support to the existing signal/profile MIPS measurement workflow, including target-specific app entrypoints, PLL init, and reference baselines so CI can profile mic-array MIPS on both XS3 and VX4.

Changes:

  • Split MIPS reference baselines into per-platform JSON files and select them at test runtime based on tools version.
  • Add VX4 implementations of the MIPS “burn”/“count” assembly routines plus a VX4B network main() and PLL initialization.
  • Update CMake and Jenkins configuration to build with distinct XS3 vs VX4 tool selections.

Reviewed changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
tests/signal/profile/test_measure_mips.py Adds tool-version-based selection of ISR modes and reference JSON; adjusts logging/threshold.
tests/signal/profile/mic_array_mips_xs3.json New XS3 baseline MIPS reference values.
tests/signal/profile/mic_array_mips_vx4.json New VX4 baseline MIPS reference values (thread mode only).
tests/signal/profile/app_mips/src/mips/count_mips.S Adds VX4 counter loop implementation.
tests/signal/profile/app_mips/src/mips/burn_mips.S Adds VX4 burn loop implementation.
tests/signal/profile/app_mips/src/main.xc Guards XC main() so it’s only compiled as XC.
tests/signal/profile/app_mips/src/main.c Adds VX4B NETWORK_MAIN entrypoint.
tests/signal/profile/app_mips/src/app_pll.c Adds VX4B PLL configuration; refactors XS3 PLL init behind app_pll_init().
tests/signal/profile/app_mips/src/app_config.h Adds VX4B port mappings.
tests/signal/profile/app_mips/src/app.c Switches from sw_pll_fixed_clock() to app_pll_init().
tests/signal/profile/app_mips/CMakeLists.txt Makes build target-dependent (XS3 vs VX4) and limits ISR variants on VX4.
tests/signal/profile/app_memory/CMakeLists.txt Removes deps.cmake include in favor of explicit dependent modules.
examples/app_mic_array_basic/vx4/device_pll_ctrl.c Comment clarification for VX4 PLL divider settings.
Jenkinsfile Splits XS3 vs VX4 tools parameters and tweaks build/test invocations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shuchitak and others added 2 commits March 19, 2026 10:03
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@shuchitak shuchitak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! Sorry about the mips test :)

@shuchitak shuchitak marked this pull request as ready for review March 19, 2026 10:19
@xalbertoisorna xalbertoisorna merged commit db7a58d into xmos:vx4 Mar 19, 2026
2 checks passed
@xalbertoisorna xalbertoisorna deleted the feature/mips-vx4 branch March 19, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants