Conversation
c6996f5 to
f3a3f45
Compare
There was a problem hiding this comment.
Pull request overview
Adds an optional low-power configuration that runs the second-stage decimator in a separate parallel task/thread, enabled via -DMIC_ARRAY_CONFIG_ENABLE_DECIMATOR_STG2_TASK=1 alongside -DMIC_ARRAY_CONFIG_LOW_POWER=1.
Changes:
- Extends mic array task startup to optionally spawn an additional “decimator stage-2” task connected via a channel.
- Adds a new
decimator_stg2_task()API + implementation and wires it into the low-power decimator path. - Updates C/C++ task entry points and configuration defaults/docs for the new build-time option.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| lib_mic_array/src/mic_array_task_internal.hpp | Updates internal task entrypoint signatures; adds stage-2 task starter declaration. |
| lib_mic_array/src/mic_array_task.cpp | Routes low-power decimator startup to 1-stage vs 2-stage-parallel path; adds stage-2 task starter. |
| lib_mic_array/src/mic_array_task.c | Spawns extra parallel job + channel when stage-2 task is enabled. |
| lib_mic_array/src/decimator_stg2_task.c | Introduces the stage-2 decimator worker task implementation. |
| lib_mic_array/api/mic_array/mic_array_conf_default.h | Documents low-power behavior and adds default for MIC_ARRAY_CONFIG_ENABLE_DECIMATOR_STG2_TASK. |
| lib_mic_array/api/mic_array/decimator_stg2_task.h | New public header for decimator_stg2_task(). |
| lib_mic_array/api/mic_array/cpp/MicArray.hpp | Adds new low-power thread entrypoints and adjusts docs. |
| lib_mic_array/api/mic_array/cpp/Decimator.hpp | Adds a channel-based parallel two-stage block processing method and c_decimator member. |
| lib_mic_array/api/mic_array.h | Exposes the new stage-2 task header via the main public include. |
Comments suppressed due to low confidence (1)
lib_mic_array/api/mic_array/cpp/MicArray.hpp:174
- The Doxygen comment for
ThreadEntry()appears corrupted ("froThsis function m ...") and will render incorrectly in generated docs. Please restore the intended sentence about collecting PDM blocks fromPdmRx(which must have already been started) and remove the stray text.
* This function does not return. It loops indefinitely, collecting blocks
* of PDM data from @ref PdmRx (which must have already been started),
* uses @ref Decimator to filter and decimate the sample stream to the
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…w power mic configurations. Enabled by defining -DMIC_ARRAY_CONFIG_ENABLE_DECIMATOR_STG2_TASK=1, in addition to -DMIC_ARRAY_CONFIG_LOW_POWER=1
f3a3f45 to
ee9c01e
Compare
| * | ||
| * This function does not return. It loops indefinitely, collecting blocks | ||
| * of PDM data from @ref PdmRx (which must have already been started), | ||
| * of PDM data froThsis function m @ref PdmRx (which mas long as OutputHandler.OutputSample () doesn't return ust have already been started), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled by defining -DMIC_ARRAY_CONFIG_ENABLE_DECIMATOR_STG2_TASK=1, in addition to -DMIC_ARRAY_CONFIG_LOW_POWER=1