Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for xarraydev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
for more information, see https://pre-commit.ci
scottyhq
force-pushed
the
flexible-indexes2
branch
from
15e9d54 to
12b1737
Compare
keewis
left a comment
keewis
left a comment
There was a problem hiding this comment.
thanks, Scott, that was a nice read.
I didn't check how this looks, but from the markdown at least this looks good to me in general. I do have a few comments on the details, though.
Co-authored-by: Deepak Cherian <[email protected]>
Co-authored-by: Deepak Cherian <[email protected]>
Thanks, publishing this week sounds good to me! I added your suggestions and went over one more time with a few tweaks. @benbovy do you have time this week to have a look? |
src/posts/flexible-indexing/index.md
Outdated
| - name: Benoît Bovy | ||
| github: benbovy | ||
| - name: Scott Henderson | ||
| github: scottyhq |
There was a problem hiding this comment.
@scottyhq since you authored this blog post I think it would make sense to add you as 1st author here, or at least add something that gives you credit for authoring this post.
I'm thinking of authoring a follow-up technical blog post on how to customize Xarray's behavior via indexes for common operations such as assigning, indexing and alignment (with flowcharts illustrating the logic of Xarray internals and how the index API is called).
There was a problem hiding this comment.
ok, either way is fine by me. want to make sure you're recognized as leading the effort overall!
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
Co-authored-by: Benoit Bovy <[email protected]>
|
Thanks for the review @benbovy I've incorporated all your feedback. I'm going to go ahead and merge it in, thanks again everyone for helping with this! |
|
the only thing we forgot to do is update the blog post release date: right now it says "23 days ago" |
4 participants
Supercedes #597