Skip to content

ci: Fix VHS action - #2459

Merged
aklinker1 merged 14 commits into
mainfrom
fix-vhs-action-again
Jun 29, 2026
Merged

ci: Fix VHS action#2459
aklinker1 merged 14 commits into
mainfrom
fix-vhs-action-again

Conversation

@aklinker1

@aklinker1 aklinker1 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Overview

Fixing action so it can generate new GIF after #2425

@netlify

netlify Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 4776381
🔍 Latest deploy log https://app.netlify.com/projects/creative-fairy-df92c4/deploys/6a42da4c29eb7c0008592528
😎 Deploy Preview https://deploy-preview-2459--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Jun 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wxt-dev/analytics

npm i https://pkg.pr.new/@wxt-dev/analytics@2459

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@2459

@wxt-dev/browser

npm i https://pkg.pr.new/@wxt-dev/browser@2459

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@2459

@wxt-dev/is-background

npm i https://pkg.pr.new/@wxt-dev/is-background@2459

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@2459

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@2459

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@2459

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@2459

@wxt-dev/runner

npm i https://pkg.pr.new/@wxt-dev/runner@2459

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@2459

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@2459

@wxt-dev/webextension-polyfill

npm i https://pkg.pr.new/@wxt-dev/webextension-polyfill@2459

wxt

npm i https://pkg.pr.new/wxt@2459

commit: 4776381

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.42%. Comparing base (8dfedf2) to head (4776381).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2459      +/-   ##
==========================================
- Coverage   78.57%   78.42%   -0.16%     
==========================================
  Files         134      134              
  Lines        3916     3916              
  Branches      890      890              
==========================================
- Hits         3077     3071       -6     
- Misses        748      753       +5     
- Partials       91       92       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aklinker1
aklinker1 marked this pull request as ready for review June 29, 2026 15:32
ded-furby and others added 2 commits June 29, 2026 10:33
Co-authored-by: Patryk Kuniczak <p.kuniczak@gmail.com>
Comment thread docs/assets/init-demo.gif

@PatrykKuniczak PatrykKuniczak Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bun is still on the very bottom:

Image

@aklinker1 aklinker1 Jun 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, just had to merge with main and re-run the workflow

@PatrykKuniczak PatrykKuniczak left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, you can place pnpm on the second place if you want to.
It's better option than npm

We can have bun as preffered, pnpm as second good and npm as third, because only IMHO it's better than yarn i don't see almost anybody which use it on project.

@aklinker1

aklinker1 commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

NPM is still the go-to package manager for a lot of people, I don't want to change the order too much. Personally, I would have just moved bun up above yarn, making the order npm, pnpm, bun, yarn, but I don't have that strong of opinions so I didn't say anything on the other PR lol.

@aklinker1
aklinker1 enabled auto-merge (squash) June 29, 2026 20:49
@aklinker1
aklinker1 merged commit d9c25ac into main Jun 29, 2026
18 checks passed
@aklinker1
aklinker1 deleted the fix-vhs-action-again branch June 29, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants