Skip to content

fix(ui): fix setting FullStory - WF-368#985

Merged
madeindjs merged 1 commit into
devfrom
WF-368-fix
Jun 30, 2025
Merged

fix(ui): fix setting FullStory - WF-368#985
madeindjs merged 1 commit into
devfrom
WF-368-fix

Conversation

@madeindjs

@madeindjs madeindjs commented Jun 30, 2025

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Refactor
    • Simplified user tracking by removing dynamic configuration fetching and switching to a fixed organization ID for FullStory integration.
    • Improved error handling during user identification to ensure all tracking operations are attempted, regardless of individual failures.

@madeindjs madeindjs self-assigned this Jun 30, 2025
@coderabbitai

coderabbitai Bot commented Jun 30, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The changes remove dynamic fetching of the FullStory organization ID and the associated environment config utility. FullStory is now initialized with a hardcoded org ID. The code eliminates the async configuration loading logic, simplifies the tracking composable, and updates promise handling for user identification.

Changes

File(s) Change Summary
src/ui/src/composables/useWriterTracking.ts Removed dynamic org ID fetching, deleted async config usage, hardcoded FullStory org ID, updated promise handling, removed unused import.
src/ui/src/utils/writerCloudEnvConfig.ts Deleted file; previously provided async environment config loading and caching utility.

Sequence Diagram(s)

sequenceDiagram
    participant App
    participant useWriterTracking
    participant FullStory

    App->>useWriterTracking: Initialize tracking
    useWriterTracking->>FullStory: Initialize with hardcoded org ID
    useWriterTracking->>FullStory: Identify user (Promise.allSettled)
Loading

Assessment against linked issues

Objective Addressed Explanation
Implement FullStory session recording for users in cloud and edit mode (AB-51)

Possibly related PRs

Poem

A bunny hopped through config code,
Once dynamic, now a simpler road.
No more fetching from the cloud,
A hardcoded path is now allowed.
With FullStory set, the tracking’s bright,
The code is lean—oh what a sight!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4909a5b and 151ec9a.

📒 Files selected for processing (2)
  • src/ui/src/composables/useWriterTracking.ts (3 hunks)
  • src/ui/src/utils/writerCloudEnvConfig.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • src/ui/src/utils/writerCloudEnvConfig.ts
⏰ Context from checks skipped due to timeout of 90000ms (15)
  • GitHub Check: build (3.12)
  • GitHub Check: build (3.13)
  • GitHub Check: build (3.9)
  • GitHub Check: build (3.10)
  • GitHub Check: build (3.10)
  • GitHub Check: build (3.11)
  • GitHub Check: build (3.13)
  • GitHub Check: build (3.12)
  • GitHub Check: build (3.11)
  • GitHub Check: build (3.9)
  • GitHub Check: tests
  • GitHub Check: tests (firefox)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)
🔇 Additional comments (3)
src/ui/src/composables/useWriterTracking.ts (3)

3-3: Good cleanup of unused import.

Removing the unused onMounted import improves code cleanliness after the dynamic config fetching logic was removed.


67-67: Excellent improvement for robust tracking initialization.

Changing from Promise.all to Promise.allSettled ensures that failure in one tracking service doesn't prevent initialization of others. This is a great defensive programming practice for analytics code.


113-113: Ensure FullStory Org ID is Configurable Across Environments

Hardcoding "o-2316W7-na1" in src/ui/src/composables/useWriterTracking.ts (line 113) is the only occurrence of a FullStory org ID in the codebase. To avoid unexpected behavior in dev/staging/production, please verify that this single ID is valid for all environments. If any environment requires a different ID, consider switching to an environment variable with a fallback:

- orgId: "o-2316W7-na1",
+ orgId: import.meta.env.VITE_FULLSTORY_ORG_ID || "o-2316W7-na1",
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hackerone-code hackerone-code Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 This pull request has been sent to HackerOne's PullRequest review team because our automation detected one or more changes with potential security impact or requires further evaluation. Experts are now being assigned to this review based on relevant expertise and will validate or dismiss any security findings accordingly and post their feedback as comments within this pull request.

⏱️ Latest scan covered changes up to commit 151ec9a (latest)


Check the status or cancel this secure code review here.

@hackerone-code hackerone-code Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Graham C reviewed all the included code changes and associated automation findings and determined that there were no immediately actionable security flaws. Note that they will continue to be notified of any new commits or comments and follow up as needed throughout the duration of this pull request's lifecycle.

Image of Graham C Graham C


Reviewed with ❤️ by PullRequest

@madeindjs
madeindjs merged commit 2342c1f into dev Jun 30, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant