Skip to content
This repository was archived by the owner on Mar 7, 2025. It is now read-only.

Use NotoSerif by default or at least a bigger font - #82

Merged
koke merged 1 commit into
masterfrom
feature/noto-fonts
Nov 28, 2018
Merged

koke merged 1 commit into
masterfrom
feature/noto-fonts

Conversation

@koke

@koke koke commented Nov 28, 2018

Copy link
Copy Markdown
Member

The existing default font was too tiny, I updated it to 16 points to match Aztec.
Also, if the NotoSerif font is available it will use that. I'm not super happy with the implementation, but making it configurable seemed like a lot of effort for now.

To test:

From WordPress-iOS, edit the Podfile and point the RNTAztecView pod to this branch:

pod 'RNTAztecView', :git => 'https://github.com/wordpress-mobile/react-native-aztec.git', :branch => 'feature/noto-fonts'

Run bundle exec pod update RNTAztecView

Run the app, create or edit a post with Gutenberg and verify that the paragraph/heading blocks are using NotoSerif

If you run the gutenberg-mobile example app, it should show paragraphs with the system fonts but at 16 points.

@koke
koke requested a review from etoledom November 28, 2018 18:04
@iamthomasbishop

Copy link
Copy Markdown

Question regarding font scaling – does this work in tandem with device-level font size preferences? I'm curious how (if at all) this will scale up/down with device settings.

@koke

koke commented Nov 28, 2018

Copy link
Copy Markdown
Member Author

It looks like it's respecting dynamic text. I can see some issues around content sizing and cropped text, and I'm not sure if the scale is correct. But at least it's responding to the setting.

Min, default, max:

gb-dynamic-text

@iamthomasbishop

Copy link
Copy Markdown

Awesome, thanks for confirming! Text sizing within editors is a tricky thing, but it's good to know where we're at.

@etoledom etoledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly as advertised for both WordPress-iOS and the Gutenberg example app! ✅

@koke

koke commented Nov 28, 2018

Copy link
Copy Markdown
Member Author

Just noting that I haven't done the Android part since I'm not familiar with the font system there, but I think the default font size was already better than iOS

@koke
koke merged commit 0db4957 into master Nov 28, 2018
@koke
koke deleted the feature/noto-fonts branch November 28, 2018 22:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants