Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix block appender placeholder not matching the paragraph placeholder issue - #732

Merged
pinarol merged 8 commits into
developfrom
issues/637-placeholder-match
Mar 12, 2019
Merged

pinarol merged 8 commits into
developfrom
issues/637-placeholder-match

Conversation

@pinarol

@pinarol pinarol commented Mar 12, 2019 •

Copy link
Copy Markdown
Contributor

Fixes: #637

gutenberg PR WordPress/gutenberg#14386

^^^ The issue contains more than 1 issues.

  1. the border makes the text go up/down 1px when it gets and loses focus -> This was already solved with Add border on Title when focused #622

  2. When we create a new post block appender's placeholder shows at a slightly different position than the paragraph placeholder so it moves the first time you tap on it. -> This is the problem we are solving in this PR

Before:

iOS:
placeholder-ios-before

Android:
placeholder-android-before

After:

iOS:
placeholder-ios-after

Android:
placeholder-android-after

TEST

For WPiOS

Checkout the PRs branch to any arbitrary folder and cd .. to it
run yarn install, yarn start
Open XCode WPiOS on the latest develop
Clean build folder on Xcode, and then run the app

For WPAndroid

open grade.properties at WordPress-Android folder
add wp.BUILD_GUTENBERG_FROM_SOURCE = true to grade.properties
checkout the PRs branch in the subrepo of WordPress-Android repo
cd to WordPress-Android/libs/gutenberg-mobile
run yarn install, yarn start
yarn wpandroid on a separate terminal in the same directory

Test Steps

  1. Open a new post
  2. Tap on "Start writing"
  3. Verify that the placeholder doesn't shift after tapping

@etoledom etoledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! 🎉

Tested via:
WordPress/gutenberg#14386 (review)

@pinarol
pinarol merged commit d4d935a into develop Mar 12, 2019
@pinarol
pinarol deleted the issues/637-placeholder-match branch March 12, 2019 15:35
@pinarol pinarol changed the title Fix block appended placeholder not matching the paragraph placeholder issue Fix block appender placeholder not matching the paragraph placeholder issue Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants