Repository navigation
Feature/lists - #704
Feature/lists#704
Conversation
# Conflicts: # gutenberg
# Conflicts: # gutenberg
# Conflicts: # gutenberg
hotchemi
left a comment
There was a problem hiding this comment.
Ignore me if it is out of the point 🙇
# Conflicts: # gutenberg
… a double empty line.
|
Here is update of the current status of this PR:
All the above are working on iOS, but on Android we have some issues:
@koke do you think after the Android issues we should merge this with a feature flag in place? @hypest do you want to tackle the Android issue? |
|
As far as I can see on Android, adding a new item to the list by tapping Enter at the end of an item is broken. Instead of adding a new bullet, the block is actually split. Haven't debugged this yet but, @SergioEstevao are you referring to that too when you say
Yeap, added it to my plans for this sprint 👍 |
|
Yes it's exactly that! When the multiline property is true pressing Enter
shouldn't send an onEnter event up that causes the split.
…On Thu, 28 Mar 2019 at 09:01, Stefanos Togoulidis ***@***.***> wrote:
As far as I can see on Android, adding a new item to the list by tapping
Enter at the end of an item is broken. Instead of adding a new bullet, the
block is actually split. Haven't debugged this yet but, @SergioEstevao
<https://github.com/SergioEstevao> are you referring to that too when you
say Aztec android needs to implement the isMultiline prop added to the
component. When this boolean parameter is on onEnter prop should only be
invoked when an Enter is pressed and the previous line is an empty line.?
@hypest <https://github.com/hypest> do you want to tackle the Android
issue?
Yeap, added it to my plans for this sprint 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#704 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnxUQb1OFt3v-qSUfoIvCg_Y7mSo8jTks5vbITBgaJpZM4bfoQN>
.
|
# Conflicts: # gutenberg
# Conflicts: # gutenberg
|
@Tug do you mind to test this. If testing on iOS please run |
| isLastBlock, | ||
| isSelected, | ||
| name, | ||
| clientId, |
There was a problem hiding this comment.
withSelect only add new props to the component, so it should not be necessary to explicitly add clientId which is already a prop given from the parent component here.
Tug
left a comment
There was a problem hiding this comment.
Nice work, we now have List ✋🎉🎈!!
Tested on both Android and iOS and it worked smoothly
# Conflicts: # react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
Generated by 🚫 dangerJS |
Refs #208
Gutenberg PR WordPress/gutenberg#14249New Gutenberg PR WordPress/gutenberg#14636
This PR implements the list block by only changing components and not touching the code of the original web block.
This achieved by improving the implementation of the block-edit context in order to send the isSelected and onFocus props to the RichText components.
For the moment it doesn't implement the indent and outdent buttons, because of a bug in Aztec for iOS that doesn't allow split to work properly when lists are indented.
If testing on iOS please run
yarn preiosto make sure you get the right version of Aztec.How to test: