Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Re-add rootTagsToEliminate option to RichText - #636

Merged
pinarol merged 2 commits into
developfrom
fix/unwanted-strong-tags
Feb 21, 2019
Merged

pinarol merged 2 commits into
developfrom
fix/unwanted-strong-tags

Conversation

@pinarol

@pinarol pinarol commented Feb 21, 2019 •

Copy link
Copy Markdown
Contributor

This PR is to re-add rootTagsToEliminate option to RichText component. Looks like it was lost by a merge regression here https://github.com/WordPress/gutenberg/pull/13874/files

Original issue was resolved here #577.

gutenberg PR needs to be merged first WordPress/gutenberg#14006

TO TEST

Follow test steps in original PR: #577
(feel free to test on develop branches on WPiOS and WPAndroid).

@koke koke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on WPiOS and it looks good 👌

@pinarol
pinarol merged commit 1fead08 into develop Feb 21, 2019
daniloercoli added a commit that referenced this pull request Feb 22, 2019
…rg-mobile into issue/609-Show-Title-block-when-HTML-mode

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (44 commits)
  Updated bundles
  Add border on Title when focused (#622)
  Default to the device language for the example app
  Updates the gutenberg submodule ref.
  Updates the gutenberg submodule reference.
  Re-add rootTagsToEliminate option to RichText (#636)
  Give priority to the parent app translations
  Remove unnecessary import
  Fix lint issue
  Fallback to a locale without a regional code if not supported
  Add Greek support
  PR got merged upstream so, use upstream
  Run yarn i18n-cache on postinstall
  Run yarn prebundle before bundle:android and bundle:ios instead
  Use a forked+patched jsdom-jscore with normalization fix
  Revert "Update GB ref with fix for node.rel"
  Upload media progress bar is missing while media is uploading new (#631)
  Remove JS handling of title focus
  Update GB ref with fix for node.rel
  Update iOS translation values as arrays
  ...
@pinarol
pinarol deleted the fix/unwanted-strong-tags branch March 13, 2019 11:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants