Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix Image caption font family error on iOS - #542

Merged
daniloercoli merged 4 commits into
developfrom
issue/372-fix-image-caption-styling-error-ios
Feb 6, 2019
Merged

daniloercoli merged 4 commits into
developfrom
issue/372-fix-image-caption-styling-error-ios

Conversation

@daniloercoli

Copy link
Copy Markdown
Contributor

This PR fixes an error on the Image block where the fontFamily was hard coded in the block, instead of reading it via CSS, and an error thrown on iOS since the family missing.

GB-side PR: WordPress/gutenberg#13677

Note: remember to update the GB ref to point to master before the merge of this PR.

@daniloercoli daniloercoli added [Type] Bug Something isn't working [OS] iOS labels Feb 5, 2019

@hypest hypest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to update the hash and merge when the Gutenberg side PR gets merged 👍

…rg-mobile into issue/372-fix-image-caption-styling-error-ios

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Update gutenberg ref to master
  Update gutenberg ref
  Update gutenberg ref
  Update Gutenberg-mobile bundle version in the app.
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
@daniloercoli
daniloercoli merged commit 3ca7a77 into develop Feb 6, 2019
@daniloercoli
daniloercoli deleted the issue/372-fix-image-caption-styling-error-ios branch February 6, 2019 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[OS] iOS [Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants