Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix full-screen bottom sheet animations - #3894

Closed
dcalhoun wants to merge 2 commits into
developfrom
bug/fix-full-screen-bottom-sheet-animations
Closed

dcalhoun wants to merge 2 commits into
developfrom
bug/fix-full-screen-bottom-sheet-animations

Conversation

@dcalhoun

Copy link
Copy Markdown
Member

Related PRs

Relates to #3883.

To test: See WordPress/gutenberg#34425.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added the [Type] Regression Existing functionality that got broken label Aug 31, 2021
@dcalhoun dcalhoun added this to the 1.61.0 (18.2) milestone Aug 31, 2021
@dcalhoun dcalhoun self-assigned this Aug 31, 2021
@peril-wordpress-mobile

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dcalhoun
dcalhoun marked this pull request as ready for review August 31, 2021 20:33
@dcalhoun
dcalhoun requested a review from mkevins August 31, 2021 20:33
@mkevins

mkevins commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Hi @dcalhoun 👋 😃 . I've been having trouble testing this because of recent changes to the gradle version on the WordPress-Android app (local builds are broken until merged with upstream changes). So, for now, I'll bump the milestone to the next release, but let me know if you think we should still get this into 1.61. Thanks!

@mkevins mkevins modified the milestones: 1.61.0 (18.2), 1.62.0 (18.3) Sep 3, 2021
@dcalhoun

dcalhoun commented Sep 9, 2021

Copy link
Copy Markdown
Member Author

Hey @mkevins. 👋🏻 Following up as I realized I may have misinterpreted your previous comment. Do I need to update this branch or complete any work to fix testing this work? Thanks!

@mkevins

mkevins commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

Hey @mkevins. 👋🏻 Following up as I realized I may have misinterpreted your previous comment. Do I need to update this branch or complete any work to fix testing this work? Thanks!

Hi @dcalhoun 👋 😃 My apologies if my comment was ambiguous 😅 . What I meant was that I didn't have a chance to test that prior to the previous release ― due to issues unrelated with your PR. I will test this today (the conflicts need to be resolved before merging, but so far no "code related" conflicts have arisen, so I can test this as is).

@mkevins

mkevins commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

Hi @dcalhoun 👋 😄

I tested this on Android (Pixel 3a physical device) and I still encountered the issue with the "ghost" screen:

Though this is not related with this PR (it occurred to me on develop as well).

For me, the animations were a bit rough when I opened the inserter. I'm not sure if this is related with this PR, or something else though 🤔 Were they smooth for you?

Here is a video of how it looks for me

bottomsheet-jank.mp4

@mkevins

mkevins commented Sep 14, 2021

Copy link
Copy Markdown
Contributor

On iOS (tested on iPhone 11 - physical device) the animations look smoother (however dismissing the inserter sometimes seems to stop at the half-way point, before disappearing, instead of animating all the way down until it is off the screen)..

The buttons block settings all animated very smoothly in my tests.

The link picker animations had some issues, e.g. sometimes the editor toolbar becomes visible during the animation away from fullscreen. Oddly, this seems to depend on whether or not the omni input was cleared before cancelling 🤔 :

cancel-animation-ios-toolbar-visible.mov

@jd-alexander

Copy link
Copy Markdown
Contributor

Hey @dcalhoun .We will cut the 1.62.0 release today so I am bumping this PR to the next milestone. Let me know if you’d rather us work to include this PR in 1.62.0. Thanks!

@twstokes

Copy link
Copy Markdown
Contributor

Hey @dcalhoun. We will cut the 1.63.0 release today. Please let me know if you’d like to bump this to the next milestone or rather us work to include this PR in 1.63.0. Thanks!

@dcalhoun dcalhoun modified the milestones: 1.63.0 (18.4), 1.64.0 (18.5) Sep 30, 2021
@dcalhoun

Copy link
Copy Markdown
Member Author

Thanks for the ping, @twstokes. I bumped this PR to the next release.

@geriux

geriux commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Hey @dcalhoun 👋. We will cut the 1.64.0 release on 10/14. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.64.0. Thanks!

@fluiddot

Copy link
Copy Markdown
Contributor

Hey @dcalhoun !
We will cut the 1.66.0 release on 2021-11-11. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.66.0. Thanks!

@fluiddot fluiddot removed this from the 1.66.0 (18.7) milestone Nov 11, 2021
@fluiddot fluiddot added this to the 1.67.0 (18.8) milestone Nov 11, 2021
@dcalhoun dcalhoun removed this from the 1.67.0 (18.8) milestone Nov 16, 2021
@dcalhoun

dcalhoun commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

Closing this PR as the related Gutenberg changes were included in other work. See WordPress/gutenberg#34425 (comment).

@dcalhoun dcalhoun closed this Jan 4, 2022
@dcalhoun
dcalhoun deleted the bug/fix-full-screen-bottom-sheet-animations branch January 4, 2022 15:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Regression Existing functionality that got broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants