Repository navigation
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Hi @dcalhoun 👋 😃 . I've been having trouble testing this because of recent changes to the gradle version on the WordPress-Android app (local builds are broken until merged with upstream changes). So, for now, I'll bump the milestone to the next release, but let me know if you think we should still get this into 1.61. Thanks! |
|
Hey @mkevins. 👋🏻 Following up as I realized I may have misinterpreted your previous comment. Do I need to update this branch or complete any work to fix testing this work? Thanks! |
Hi @dcalhoun 👋 😃 My apologies if my comment was ambiguous 😅 . What I meant was that I didn't have a chance to test that prior to the previous release ― due to issues unrelated with your PR. I will test this today (the conflicts need to be resolved before merging, but so far no "code related" conflicts have arisen, so I can test this as is). |
|
Hi @dcalhoun 👋 😄 I tested this on Android (Pixel 3a physical device) and I still encountered the issue with the "ghost" screen: Though this is not related with this PR (it occurred to me on develop as well). For me, the animations were a bit rough when I opened the inserter. I'm not sure if this is related with this PR, or something else though 🤔 Were they smooth for you? Here is a video of how it looks for me bottomsheet-jank.mp4 |
|
On iOS (tested on iPhone 11 - physical device) the animations look smoother (however dismissing the inserter sometimes seems to stop at the half-way point, before disappearing, instead of animating all the way down until it is off the screen).. The buttons block settings all animated very smoothly in my tests. The link picker animations had some issues, e.g. sometimes the editor toolbar becomes visible during the animation away from fullscreen. Oddly, this seems to depend on whether or not the omni input was cleared before cancelling 🤔 : cancel-animation-ios-toolbar-visible.mov |
|
Hey @dcalhoun .We will cut the 1.62.0 release today so I am bumping this PR to the next milestone. Let me know if you’d rather us work to include this PR in 1.62.0. Thanks! |
|
Hey @dcalhoun. We will cut the 1.63.0 release today. Please let me know if you’d like to bump this to the next milestone or rather us work to include this PR in 1.63.0. Thanks! |
|
Thanks for the ping, @twstokes. I bumped this PR to the next release. |
|
Hey @dcalhoun 👋. We will cut the 1.64.0 release on 10/14. I plan to circle back and bump this PR to the next milestone then, but please let me know if you'd rather us work to include this PR in 1.64.0. Thanks! |
|
Hey @dcalhoun ! |
|
Closing this PR as the related Gutenberg changes were included in other work. See WordPress/gutenberg#34425 (comment). |

Related PRs
Relates to #3883.
To test: See WordPress/gutenberg#34425.
PR submission checklist: