This repository was archived by the owner on Jul 9, 2026. It is now read-only.
Repository navigation
Update userAgent override to be string instead of array - #3880
Merged
Merged
Conversation
7 tasks done
mchowning
approved these changes
Aug 26, 2021
mchowning
left a comment
Contributor
There was a problem hiding this comment.
Approved via WordPress/gutenberg#34308 (review)
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issues that arose while working on the Jetpack Tiled Gallery (see #3875) where we ran into an error because the JSDOM user agent is incorrectly overridden to be an empty array, instead of an empty string. The
debugthird-party libraries used by Jetpack queried the user agent crashed when it encountered the wrong type (expected string, got array).Related:
To test, ensure CI checks pass.
PR submission checklist: