Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Update GB hash and fix Keyboard dismissed when enter.key is pressed - #383

Merged
daniloercoli merged 2 commits into
masterfrom
issue/381-Keyboard-gets-dismissed-when-enter.key
Dec 14, 2018
Merged

daniloercoli merged 2 commits into
masterfrom
issue/381-Keyboard-gets-dismissed-when-enter.key

Conversation

@daniloercoli

@daniloercoli daniloercoli commented Dec 14, 2018 •

Copy link
Copy Markdown
Contributor

This PR updates the GB hash and fixes #381 by reverting the changes introduced #341

Testing steps:

  • Tap on a para block
  • Tap enter
  • The new block should be created and the keyboard is up

Repeat the step above for Heading and Title block.

GB side companion PR: WordPress/gutenberg#12886

Make sure to re-open #308 when this is merged for the alpha.

@mzorz mzorz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Make sure to re-open #308 when this is merged for the alpha.

remember to do it on merge ! :D

@daniloercoli
daniloercoli merged commit 10b428b into master Dec 14, 2018
@daniloercoli
daniloercoli deleted the issue/381-Keyboard-gets-dismissed-when-enter.key branch December 14, 2018 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants