Repository navigation
Add command for forcing the i18n cache to get updated - #3717
Conversation
9ee5839 to
0783751
Compare
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
@fluiddot, let me know if you'd still like to include this in 1.58.0. If not, we can bump this to the next milestone after we've finished cutting the release. :) Thanks! |
Thanks for the heads up, I'm going to bump this to the next milestone 👍 . |
There was a problem hiding this comment.
LGTM. Thank you for your patience while I found time to review this.
I've made a diff between both versions and although it includes the previously missed strings, there's still a high number of missing strings so we shouldn't refresh the cache yet unless we can guarantee that the Gutenberg translations are not missing critical strings.
[...]
In the meantime, I created this issue as a follow-up to address it in the future.
It looked like WordPress/gutenberg#33364 has closed, so does that mean we are OK to merge this work?
Compare the previous version of translations (we could use theAs described in the PR, there are missing strings so this step can't be verified.en-gb.jsonfile) with the new one, and verify that critical strings (like block titles) are not missing.
I did perform a quick verification of en-gb.json and found that the block titles and the "missing strings" called out in the PR description (for the handful that I checked) did appear present.
Yeah, although after this PR there will be a new one that incorporates the new command into the release script to always update the Gutenberg translations when cutting a release.
Right, since the GB 11.1 version is released, the missing strings are now back, thanks for checking it 🙇 ! |
Context
Currently, we're using the Gutenberg translation files that were cached when cutting the version
1.52.2(PR), we couldn't update them until now because the translations were missing a lot of strings like the block titles displayed in the inserter menu. This was caused by the issue described here, now that is addressed we can start updating the cache when generating a new bundle, and for this purpose, we need a command that refreshes these files.The new command is
i18n:gutenberg:force, which basically downloads the Gutenberg translations from the Gutenberg GlotPress project and replaces the files located insrc/i18n-cache/gutenberg/data.Cache update restuls
I've made a diff between both versions and although it includes the previously missed strings, there's still a high number of missing strings so we shouldn't refresh the cache yet unless we can guarantee that the Gutenberg translations are not missing critical strings.
New strings (247)
Removed strings (805)⚠️
In the meantime, I created this issue as a follow-up to address it in the future.
To test:
npm run i18n:gutenberg:forcesrc/i18n-cache/gutenberg/dataare updatedCompare the previous version of translations (we could use theAs described in the PR, there are missing strings so this step can't be verified.en-gb.jsonfile) with the new one, and verify that critical strings (like block titles) are not missing.PR submission checklist: