Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Remove usage of ColorEdit in the Button block - #3691

Merged
chipsnyder merged 3 commits into
developfrom
fix/colors-gradients-hook
Jul 1, 2021
Merged

chipsnyder merged 3 commits into
developfrom
fix/colors-gradients-hook

Conversation

@geriux

@geriux geriux commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

Gutenberg PR -> WordPress/gutenberg#33103

After merging the Global styles implementation WordPress/gutenberg#30544 a bug was found where the color settings would show up duplicated for the Button block and the gradients option wouldn't show up. For more information and test plan check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux added the bugfix label Jul 1, 2021
@geriux
geriux requested a review from chipsnyder July 1, 2021 11:25
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Jul 1, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@chipsnyder

Copy link
Copy Markdown
Contributor

Tested with WordPress/gutenberg#33103 (review) and everything worked great!

Can we rerun the bundle with this merge? That way I can include these changes with the merge of wordpress-mobile/WordPress-iOS#16411

@chipsnyder chipsnyder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant for this comment to be an approval not a comment :)

Also since your EOD I can help with the merge process here

@chipsnyder
chipsnyder merged commit 67c328e into develop Jul 1, 2021
@chipsnyder
chipsnyder deleted the fix/colors-gradients-hook branch July 1, 2021 16:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants