Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix ShouldInsertAtTheTop setting calculation - #3538

Merged
fluiddot merged 4 commits into
developfrom
fix/insertion-point-title-selected
May 24, 2021
Merged

fluiddot merged 4 commits into
developfrom
fix/insertion-point-title-selected

Conversation

@fluiddot

@fluiddot fluiddot commented May 21, 2021 •

Copy link
Copy Markdown
Contributor

gutenberg PR: WordPress/gutenberg#32110

Fixes the issue identified after merging the reusable block PR into develop (UI test reference).

To test:
Follow testing instructions from Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added the [Type] Bug Something isn't working label May 21, 2021
@fluiddot fluiddot added this to the 1.54.0 (17.5) milestone May 21, 2021
@fluiddot
fluiddot requested review from dcalhoun and geriux May 21, 2021 18:20
@fluiddot fluiddot self-assigned this May 21, 2021
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented May 24, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot

Copy link
Copy Markdown
Contributor Author

All tests (including optional) were 🟢 in the previous commit to the update with the merge commit.

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fluiddot
fluiddot merged commit 67fcf4f into develop May 24, 2021
@fluiddot
fluiddot deleted the fix/insertion-point-title-selected branch May 24, 2021 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants