Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fixes color picker segmented control rendering and scrolling issues - #3394

Merged
antonis merged 1 commit into
developfrom
issue/30878-colorpicker
May 7, 2021
Merged

antonis merged 1 commit into
developfrom
issue/30878-colorpicker

Conversation

@antonis

@antonis antonis commented Apr 20, 2021 •

Copy link
Copy Markdown

Fixes: WordPress/gutenberg#30878 and #3104

gutenberg: WordPress/gutenberg#30994
WordPress-Android: wordpress-mobile/WordPress-Android#14492
WordPress-iOS: wordpress-mobile/WordPress-iOS#16366

To test:
Follow the steps on the gutenberg pr

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@antonis antonis changed the title Gutenberg reference Fixes color picker segmented control rendering and scrolling issues Apr 20, 2021
@antonis
antonis marked this pull request as ready for review April 20, 2021 11:07
@antonis
antonis requested review from dcalhoun, fluiddot and geriux April 20, 2021 11:08
@antonis antonis self-assigned this Apr 20, 2021
@antonis antonis added the [Type] Bug Something isn't working label Apr 20, 2021
@antonis antonis added this to the 1.52.0 (17.3) milestone Apr 20, 2021
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Apr 21, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis
antonis marked this pull request as draft April 22, 2021 14:35
@antonis
antonis force-pushed the issue/30878-colorpicker branch from c9c61c7 to 46efa4b Compare April 23, 2021 11:02
@antonis
antonis force-pushed the issue/30878-colorpicker branch 2 times, most recently from 50f020a to 19740e7 Compare April 27, 2021 08:56
@antonis
antonis marked this pull request as ready for review April 27, 2021 11:06
@antonis antonis removed this from the 1.52.0 (17.3) milestone Apr 29, 2021
@cameronvoell

cameronvoell commented Apr 30, 2021 •

Copy link
Copy Markdown
Contributor

Hey @antonis. 👋🏻 We will cut the 1.52.0 release Friday 30 April. Please let me know if you're aiming to include this PR in 1.52.0. Otherwise perhaps we can add the milestone label for 1.53.0 Thanks! 🙇

@antonis
antonis force-pushed the issue/30878-colorpicker branch from 1482355 to 77c961d Compare May 6, 2021 11:22

@dcalhoun dcalhoun left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approved via WordPress/gutenberg#30994 (review). I left one question regarding the bundle translation strings, but I think this is ready to merge.

_ = NSLocalizedString("50 / 50", comment: "")
_ = NSLocalizedString("70 / 30", comment: "")
_ = NSLocalizedString("9:16", comment: "")
_ = NSLocalizedString("A calendar of your site’s posts.", comment: "")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if these removals are of consequence? I wonder if they are accurate removals or potentially erroneous changes occurring due to outdated i18n files. Possibly related to #3423? WDYT?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only merge the Gutenberg reference update and not the rest, I'm guessing they were only present to be able to test the builds right @antonis? If so we can just update this PR to only have the GB commit hash change before merging.

@antonis antonis May 7, 2021 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing this @dcalhoun! I really appreciate the time you put on this 🙇

Do you know if these removals are of consequence? I wonder if they are accurate removals or potentially

Nice catch. I'm not sure why the changes were introduced. It should be related with #3423. I've only run bundle and not prebundle btw 😕

I think we should only merge the Gutenberg reference update and not the rest

I would agree with @geriux on this. I would just update the reference. The rest was just needed to be able to produce the App builds for testing.

@antonis
antonis force-pushed the issue/30878-colorpicker branch from 77c961d to 3916593 Compare May 7, 2021 09:16
@antonis antonis added this to the 1.53.0 (17.4) milestone May 7, 2021
@antonis
antonis merged commit 6435c13 into develop May 7, 2021
@antonis
antonis deleted the issue/30878-colorpicker branch May 7, 2021 09:39
@geriux geriux mentioned this pull request May 7, 2021
2 tasks done
@AmandaRiu AmandaRiu mentioned this pull request May 14, 2021
3 of 4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants