Repository navigation
Fixes color picker segmented control rendering and scrolling issues - #3394
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
c9c61c7 to
46efa4b
Compare
50f020a to
19740e7
Compare
|
Hey @antonis. 👋🏻 We will cut the 1.52.0 release Friday 30 April. Please let me know if you're aiming to include this PR in 1.52.0. Otherwise perhaps we can add the milestone label for 1.53.0 Thanks! 🙇 |
1482355 to
77c961d
Compare
There was a problem hiding this comment.
LGTM. Approved via WordPress/gutenberg#30994 (review). I left one question regarding the bundle translation strings, but I think this is ready to merge.
| _ = NSLocalizedString("50 / 50", comment: "") | ||
| _ = NSLocalizedString("70 / 30", comment: "") | ||
| _ = NSLocalizedString("9:16", comment: "") | ||
| _ = NSLocalizedString("A calendar of your site’s posts.", comment: "") |
There was a problem hiding this comment.
Do you know if these removals are of consequence? I wonder if they are accurate removals or potentially erroneous changes occurring due to outdated i18n files. Possibly related to #3423? WDYT?
There was a problem hiding this comment.
I think we should only merge the Gutenberg reference update and not the rest, I'm guessing they were only present to be able to test the builds right @antonis? If so we can just update this PR to only have the GB commit hash change before merging.
There was a problem hiding this comment.
Thank you for reviewing this @dcalhoun! I really appreciate the time you put on this 🙇
Do you know if these removals are of consequence? I wonder if they are accurate removals or potentially
Nice catch. I'm not sure why the changes were introduced. It should be related with #3423. I've only run bundle and not prebundle btw 😕
I think we should only merge the Gutenberg reference update and not the rest
I would agree with @geriux on this. I would just update the reference. The rest was just needed to be able to produce the App builds for testing.
77c961d to
3916593
Compare
Fixes: WordPress/gutenberg#30878 and #3104
gutenberg: WordPress/gutenberg#30994WordPress-Android: wordpress-mobile/WordPress-Android#14492WordPress-iOS: wordpress-mobile/WordPress-iOS#16366To test:
Follow the steps on the
gutenbergprPR submission checklist: