Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Audio & Video block - Autoplay BottomSheet Cell help support - #3380

Merged
hypest merged 6 commits into
developfrom
rnmobile/add/bottomsheet-cell-help
May 18, 2021
Merged

hypest merged 6 commits into
developfrom
rnmobile/add/bottomsheet-cell-help

Conversation

@jd-alexander

Copy link
Copy Markdown
Contributor

Fixes #3169
Gutenberg PR WordPress/gutenberg#30885
To test:
Visit WordPress/gutenberg#30885
PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Apr 16, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell

Copy link
Copy Markdown
Contributor

Hey @jd-alexander. 👋🏻 We will cut the 1.52.0 release Friday 30 April. I plan to circle back and bump this PR to the next milestone (1.53.0) on Friday, but please let me know if you'd rather us work to include this PR in 1.52.0. Thanks! 🙇

@jd-alexander
jd-alexander requested a review from AmandaRiu May 12, 2021 05:03
@AmandaRiu AmandaRiu self-assigned this May 13, 2021

@AmandaRiu AmandaRiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in the gutenberg PR. :shipit:

@ceyhun

ceyhun commented May 14, 2021

Copy link
Copy Markdown
Contributor

Hey there @jd-alexander 👋 We'll be cutting the 1.53.0 release some time soon today. I'm bumping this PR to 1.54.0 milestone, please let us know if it needs to make it into 1.53.0 instead.

@ceyhun ceyhun modified the milestones: 1.53.0 (17.4), 1.54.0 (17.5) May 14, 2021
@jd-alexander

Copy link
Copy Markdown
Contributor Author

Hey there @jd-alexander 👋 We'll be cutting the 1.53.0 release some time soon today. I'm bumping this PR to 1.54.0 milestone, please let us know if it needs to make it into 1.53.0 instead.

Thanks @ceyhun I was trying to merge it last night but the admin tests on Gutenberg kept failing. Is it too late to include it now?

@jd-alexander

Copy link
Copy Markdown
Contributor Author

@ceyhun since the release has been cut this can wait until 1.54.0.

@hypest

hypest commented May 18, 2021

Copy link
Copy Markdown
Contributor

I admin-merged the Gutenberg PR and went ahead and updated this PR as well. Since it's LGTM'd already, I'll have it auto-merge on CI green 👍.

@hypest
hypest enabled auto-merge May 18, 2021 07:54
@hypest
hypest merged commit b02d92e into develop May 18, 2021
@hypest
hypest deleted the rnmobile/add/bottomsheet-cell-help branch May 18, 2021 08:14
@fluiddot

Copy link
Copy Markdown
Contributor

@jd-alexander

Copy link
Copy Markdown
Contributor Author

Heads up that this PR has modified the Jetpack reference to an older commit: https://github.com/wordpress-mobile/gutenberg-mobile/pull/3380/files#diff-2c96c4dc757597cce968020825526dcad5205b57ef92cad5215e587fa9722627

Screenshot 2021-05-18 at 18 39 24

Thanks. I will fix this. It's the tool I use Gitkraken that modifies the jetpack reference when I use it so I normally check before merging and revert. I will open an issue with them. 🙏🏾

@fluiddot

Copy link
Copy Markdown
Contributor

Thanks. I will fix this. It's the tool I use Gitkraken that modifies the jetpack reference when I use it so I normally check before merging and revert. I will open an issue with them. 🙏🏾

I use Fork and it does the same thing with the submodule references, in my case I always discard the changes when switching branches to prevent this issue.

@hypest

hypest commented May 19, 2021

Copy link
Copy Markdown
Contributor

Heads up that this PR has modified the Jetpack reference to an older commit

Ouch, sorry, didn't catch the Jetpack ref change myself either while looking at the diff 😢

@jhnstn jhnstn mentioned this pull request May 28, 2021
4 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add help behavior to the SwitchCell component

6 participants