Repository navigation
Audio & Video block - Autoplay BottomSheet Cell help support - #3380
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Hey @jd-alexander. 👋🏻 We will cut the 1.52.0 release Friday 30 April. I plan to circle back and bump this PR to the next milestone (1.53.0) on Friday, but please let me know if you'd rather us work to include this PR in 1.52.0. Thanks! 🙇 |
AmandaRiu
left a comment
There was a problem hiding this comment.
Approved in the gutenberg PR. ![]()
|
Hey there @jd-alexander 👋 We'll be cutting the 1.53.0 release some time soon today. I'm bumping this PR to 1.54.0 milestone, please let us know if it needs to make it into 1.53.0 instead. |
Thanks @ceyhun I was trying to merge it last night but the admin tests on Gutenberg kept failing. Is it too late to include it now? |
|
@ceyhun since the release has been cut this can wait until 1.54.0. |
|
I admin-merged the Gutenberg PR and went ahead and updated this PR as well. Since it's LGTM'd already, I'll have it auto-merge on CI green 👍. |
|
Heads up that this PR has modified the Jetpack reference to an older commit: https://github.com/wordpress-mobile/gutenberg-mobile/pull/3380/files#diff-2c96c4dc757597cce968020825526dcad5205b57ef92cad5215e587fa9722627 |
Thanks. I will fix this. It's the tool I use Gitkraken that modifies the jetpack reference when I use it so I normally check before merging and revert. I will open an issue with them. 🙏🏾 |
I use Fork and it does the same thing with the submodule references, in my case I always discard the changes when switching branches to prevent this issue. |
Ouch, sorry, didn't catch the Jetpack ref change myself either while looking at the diff 😢 |

Fixes #3169
Gutenberg PRWordPress/gutenberg#30885To test:
Visit WordPress/gutenberg#30885
PR submission checklist: