Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Use the default div tagName on native for the Quote block - #3352

Merged
guarani merged 2 commits into
developfrom
30548-fix-quote-split-no-tagname
Apr 9, 2021
Merged

guarani merged 2 commits into
developfrom
30548-fix-quote-split-no-tagname

Conversation

@guarani

@guarani guarani commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

Fixes WordPress/gutenberg#30548

To test:
See WordPress/gutenberg#30645

PR submission checklist:

  • I have considered adding unit tests where possible.
    • I think a snapshot test is needed but I'm prioritizing merging this for the 1.50.1 betafix (I created an issue here)
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani
guarani requested a review from jd-alexander April 9, 2021 01:10
@guarani guarani added the bugfix label Apr 9, 2021
@guarani guarani changed the title Update gutenberg submodule ref Use the default div tagName on native for the Quote block Apr 9, 2021
@guarani
guarani enabled auto-merge April 9, 2021 01:26
@guarani
guarani disabled auto-merge April 9, 2021 01:26

@jd-alexander jd-alexander left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peril-wordpress-mobile

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@guarani
guarani enabled auto-merge April 9, 2021 02:37
@guarani
guarani merged commit f436df3 into develop Apr 9, 2021
@guarani
guarani deleted the 30548-fix-quote-split-no-tagname branch April 9, 2021 03:01
@guarani guarani added this to the 1.50.1 (17.1) milestone Apr 9, 2021
@dcalhoun dcalhoun mentioned this pull request Apr 16, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile: Splitting a Quote block citation results in nested cite tags

2 participants