Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Merge release 1.48.0 to develop - #3240

Merged
enejb merged 10 commits into
developfrom
merge_release_1.48.0_to_develop
Mar 10, 2021
Merged

enejb merged 10 commits into
developfrom
merge_release_1.48.0_to_develop

Conversation

@enejb

@enejb enejb commented Mar 9, 2021

Copy link
Copy Markdown
Contributor

Brings back changes from 1.48.0 release to develop

Gutenberg PR: WordPress/gutenberg#29445

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@enejb
enejb requested a review from geriux March 9, 2021 17:58
@enejb enejb self-assigned this Mar 9, 2021
_ = NSLocalizedString("Add Block After", comment: "")
_ = NSLocalizedString("Add Block Before", comment: "")
_ = NSLocalizedString("ADD BLOCK HERE", comment: "")
_ = NSLocalizedString("Add button text", comment: "")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization Comment Violation: Localized strings should include a description giving context for how the string is used. (localization_comment)

@peril-wordpress-mobile

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@enejb

enejb commented Mar 10, 2021

Copy link
Copy Markdown
Contributor Author

Since this is autogenerated files I am going to ignore the comment for now from hound and merge this PR.

@enejb
enejb merged commit 5693d34 into develop Mar 10, 2021
@enejb
enejb deleted the merge_release_1.48.0_to_develop branch March 10, 2021 18:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants