Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Search Block: Master PR - #3210

Merged
AmandaRiu merged 34 commits into
developfrom
add/search-block-main
Apr 26, 2021
Merged

AmandaRiu merged 34 commits into
developfrom
add/search-block-main

Conversation

@AmandaRiu

@AmandaRiu AmandaRiu commented Mar 3, 2021 •

Copy link
Copy Markdown
Contributor

Related to #3073. Instead of creating a new PR for every PR reviewed in Gutenberg, Cameron and I thought it'd make more sense to just have a master PR for updating the gutenberg reference for testing but not merging until the Search block has been added to the initial-html.js or has breaking tests. This way this PR can act as a record of all the PRs and it will be easier to parse.

  • The last entry in the table below with the ☑️ will be the active gutenberg reference under test.
  • Once the gutenberg PR has been merged it will be updated with the ✅ symbol.

This PR is now ready for merge once the last PR in the table below has been approved and merged

Gutenberg PR Merged
Search Block - Add to inserter ✅
Search Block: Add block toolbar options ✅
Search Block: Basic UI ✅
Search Block: Add button position UI support ✅
Search Block: Width Setting ✅
Search Block: Fix iOS Focus Issues ✅
Search Block: Move Block Toolbar options to settings panel ✅
Search block: Styling ✅
Search block: Accessibility ✅
Search block: Unit Tests ✅
Search block: Long button text handling ✅
Search block: UI Tests ✅

To test

Click the active Gutenberg PR in the table to view full test instructions.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Mar 3, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@AmandaRiu
AmandaRiu requested a review from guarani April 16, 2021 19:03
Comment thread RELEASE-NOTES.txt Resolved
@guarani

guarani commented Apr 23, 2021

Copy link
Copy Markdown
Contributor

Being new on the block 😏, I think the search block gets an invite to the "other block list", as suggested here.
I think it's easy to miss so thought I'd mention it in case it's not on your radar.

@dcalhoun

Copy link
Copy Markdown
Member

@AmandaRiu I attempted to test this branch within WPiOS via setting the gutenberg ref to this branch's last commit. I also attempted by checking out this branch, npm run bundle, and LOCAL_GUTENBERG=true bundle exec pod install. However, the Search block would not show up within the block inserter menu. Am I overlooking something?

@AmandaRiu

Copy link
Copy Markdown
Contributor Author

Oh thank you @guarani for this information:

Being new on the block 😏, I think the search block gets an invite to the "other block list", as suggested here.
I think it's easy to miss so thought I'd mention it in case it's not on your radar.

I had completely missed that.

@AmandaRiu

Copy link
Copy Markdown
Contributor Author

@AmandaRiu I attempted to test this branch within WPiOS via setting the gutenberg ref to this branch's last commit. I also attempted by checking out this branch, npm run bundle, and LOCAL_GUTENBERG=true bundle exec pod install. However, the Search block would not show up within the block inserter menu. Am I overlooking something?

@dcalhoun I think it may have been because I hadn't added the search block to the supported blocks in gutenberg mobile as @guarani had pointed out in this comment.. I've added it now though so it should work 🤞

@dcalhoun dcalhoun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. :shipit: I tested this, with a focus on WordPress/gutenberg#30783, on an iPhone SE and Samsung Galaxy S20.

We'll just need to change the gutenberg ref to a merge commit before merging this work.

@AmandaRiu
AmandaRiu merged commit b3d2925 into develop Apr 26, 2021
@AmandaRiu
AmandaRiu deleted the add/search-block-main branch April 26, 2021 14:31
@cameronvoell cameronvoell mentioned this pull request May 1, 2021
4 tasks done
@AmandaRiu AmandaRiu added this to the 1.52.0 (17.3) milestone May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants