Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Search Block 4: Implement button position UI - #3196

Merged
AmandaRiu merged 3 commits into
developfrom
add/search-block-button-position
Mar 2, 2021
Merged

AmandaRiu merged 3 commits into
developfrom
add/search-block-button-position

Conversation

@AmandaRiu

@AmandaRiu AmandaRiu commented Feb 25, 2021 •

Copy link
Copy Markdown
Contributor

Related to #3073. Updates the gutenberg reference to point to the branch that adds the UI logic for button position options in the block toolbar (dev mode only). This is just one of many PR steps for this block.

Gutenberg PR

WordPress/gutenberg#29096

To Test

Please follow the test instructions in the Gutenberg PR.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@cameronvoell cameronvoell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#29096 (review) .

Should be ready to merge once gutenberg side is merged and we update the reference here 👍

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Mar 2, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@AmandaRiu
AmandaRiu merged commit fea8553 into develop Mar 2, 2021
@AmandaRiu
AmandaRiu deleted the add/search-block-button-position branch March 2, 2021 23:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants