Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fixes crash when selecting a gradient style - #3166

Merged
antonis merged 3 commits into
developfrom
fix/3157-gradient_crash
Feb 17, 2021
Merged

antonis merged 3 commits into
developfrom
fix/3157-gradient_crash

Conversation

@antonis

@antonis antonis commented Feb 17, 2021 •

Copy link
Copy Markdown

Fixes #3157

gutenberg pr: WordPress/gutenberg#29072

To test:

Note

The tests below should be executed both with a simple theme and with a theme defining custom gradients (eg. Twenty-Twenty)

Button block

  1. Add a button block
  2. Open the block settings
  3. Select background color
  4. Choose gradient from the segmented control
  5. Tap on any gradient style
  6. Verify that the app does not crash

Cover block

  1. Add a cover block
  2. Tap on any color and apply
  3. Open the block settings
  4. Select Color
  5. Choose gradient from the segmented control
  6. Tap on any gradient style
  7. Verify that the app does not crash

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonis
antonis changed the base branch from release/1.47.0 to develop February 17, 2021 12:41
@antonis
antonis force-pushed the fix/3157-gradient_crash branch from 102f1b0 to 22ae1a1 Compare February 17, 2021 12:42
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Feb 17, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@antonis
antonis merged commit 36d92f8 into develop Feb 17, 2021
@antonis
antonis deleted the fix/3157-gradient_crash branch February 17, 2021 14:16
@enejb enejb mentioned this pull request Mar 1, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Selecting a Gradient style crashes the App

2 participants