Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Ignore column width attribute when empty - #3151

Merged
guarani merged 5 commits into
developfrom
ignore-empty-column-width-attribute
Feb 16, 2021
Merged

guarani merged 5 commits into
developfrom
ignore-empty-column-width-attribute

Conversation

@guarani

@guarani guarani commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

Fixes WordPress/gutenberg#29017

To test:
WordPress/gutenberg#29015

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@guarani
guarani requested a review from lukewalczak February 16, 2021 01:26
@guarani guarani added the [Type] Bug Something isn't working label Feb 16, 2021
@guarani guarani added this to the 1.47 (16.8) milestone Feb 16, 2021
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Feb 16, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot

Copy link
Copy Markdown
Contributor

👋 I've just updated the Gutenberg submodule reference to leave this PR ready.

@fluiddot fluiddot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested and approved via WordPress/gutenberg#29015 (review).

@fluiddot

Copy link
Copy Markdown
Contributor

@guarani I was wondering if we should update the title with something similar to the gutenberg PR, I think it could be a bit misleading when someone checks the milestone for 1.47, what do you think?

@guarani guarani changed the title Update gutenberg submodule ref Ignore column width attribute when empty Feb 16, 2021
@guarani

guarani commented Feb 16, 2021

Copy link
Copy Markdown
Contributor Author

@guarani I was wondering if we should update the title with something similar to the gutenberg PR, I think it could be a bit misleading when someone checks the milestone for 1.47, what do you think?

Thanks for flagging – updated now! (it took the title of my equally poorly named commit and used it as a title and I hadn't noticed)

@guarani
guarani merged commit be938b8 into develop Feb 16, 2021
@guarani
guarani deleted the ignore-empty-column-width-attribute branch February 16, 2021 13:33
@fluiddot

Copy link
Copy Markdown
Contributor

I'm moving this PR to the 1.46.1 milestone because it was integrated in that version.

@fluiddot fluiddot modified the milestones: 1.47 (16.8), 1.46.1 (16.7) Feb 17, 2021
@guarani

guarani commented Feb 17, 2021

Copy link
Copy Markdown
Contributor Author

I'm moving this PR to the 1.46.1 milestone because it was integrated in that version.

Thanks for updating that, @fluiddot!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor crash on column block with empty width attribute

2 participants