Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix block validation errors - #310

Merged
Tug merged 9 commits into
masterfrom
fix/validation-errors
Dec 4, 2018
Merged

Tug merged 9 commits into
masterfrom
fix/validation-errors

Conversation

@Tug

@Tug Tug commented Dec 3, 2018 •

Copy link
Copy Markdown
Contributor

Requires WordPress/gutenberg#12552

Fix "Block validation failed for core/paragraph... " errors when trying the demo post content from gutenberg.

For this we remove the babel transform react-native-classname-to-style which would cause unexpected result when saving blocks and thus validation errors.

This PR also removes some unused dependencies and others that are already provided by @wordpress/babel-preset-default.

Lastly, it updates the initial-html.js and appends the whole content of the gutenberg demo post which can be found here https://wordpress.org/gutenberg/

Comment thread .flowconfig
<PROJECT_ROOT>/node_modules/fbjs/.*
<PROJECT_ROOT>/node_modules/graphql/.*
<PROJECT_ROOT>/node_modules/prettier/.*
<PROJECT_ROOT>/node_modules/jsx-to-string/.*

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like those are necessary sometimes, let's just add those

@pinarol
pinarol self-requested a review December 4, 2018 09:28

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Tested with both with iOS example app and with this post on WP-iOS side, it used to display lots of validation errors now it doesn't.

@Tug
Tug force-pushed the fix/validation-errors branch from 267b43f to 42fd5c4 Compare December 4, 2018 09:32
@Tug
Tug force-pushed the fix/validation-errors branch from 42fd5c4 to 734b021 Compare December 4, 2018 09:36
@Tug
Tug merged commit f3ce0a4 into master Dec 4, 2018
@Tug
Tug deleted the fix/validation-errors branch December 4, 2018 09:46
@Tug Tug mentioned this pull request Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants