Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Move custom indicator to be rendered above the colors - #3098

Merged
lukewalczak merged 2 commits into
developfrom
fix-seg-controls-crash
Feb 4, 2021
Merged

lukewalczak merged 2 commits into
developfrom
fix-seg-controls-crash

Conversation

@lukewalczak

Copy link
Copy Markdown
Contributor

Fixes: #3097

To test:

  1. Go to a post/page.
  2. Add Buttons block.
  3. Tap on the gear button.
  4. Tap on Background Color options.
  5. Switch several times between Solid and Gradient segments.
    Expect app mustn't crash

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak changed the title Update ref: Move custom indicator to be rendered above the colors to … Move custom indicator to be rendered above the colors Feb 3, 2021
@fluiddot
fluiddot self-requested a review February 3, 2021 17:03
@fluiddot fluiddot added the [Type] Bug Something isn't working label Feb 3, 2021

@fluiddot fluiddot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved via WordPress/gutenberg#28698 (review).

@fluiddot fluiddot mentioned this pull request Feb 3, 2021
3 tasks done
@fluiddot

fluiddot commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

@lukewalczak I think this PR is ready to be merged, although first we should resolve the conflict in the gutenberg submodule reference.

@peril-wordpress-mobile

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@lukewalczak
lukewalczak merged commit a48e252 into develop Feb 4, 2021
@lukewalczak
lukewalczak deleted the fix-seg-controls-crash branch February 4, 2021 12:49
@fluiddot fluiddot added this to the 1.46 (16.7) milestone Feb 4, 2021
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Colors segmented controls crash when switching quick

2 participants