Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

[FIX] Bottom-sheet height after using back button - #3080

Merged
dratwas merged 2 commits into
developfrom
fix/bottom-sheet-height
Feb 1, 2021
Merged

dratwas merged 2 commits into
developfrom
fix/bottom-sheet-height

Conversation

@dratwas

@dratwas dratwas commented Feb 1, 2021

Copy link
Copy Markdown
Contributor

Fixes the issue with the height of bottom-sheet when we back from another screen inside it.

GB PR: WordPress/gutenberg#28632

To test:

  1. add button block
  2. open settings
  3. open the background color settings
  4. select gradient segment
  5. open "customize gradient"
  6. use the back button on the top left of bottom-sheet
  7. switch to solid segment
  8. switch back to the gradient segment
  9. the height should be changed

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@dratwas
dratwas requested a review from lukewalczak February 1, 2021 16:41

@lukewalczak lukewalczak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peril-wordpress-mobile

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@dratwas
dratwas merged commit a7ffea7 into develop Feb 1, 2021
@dratwas
dratwas deleted the fix/bottom-sheet-height branch February 1, 2021 17:49
@fluiddot

fluiddot commented Feb 2, 2021

Copy link
Copy Markdown
Contributor

👋 @dratwas since this is going to be included in version 1.46.0, I've just assigned the PR to the version milestone.

@fluiddot fluiddot added this to the 1.46 (16.7) milestone Feb 2, 2021
@fluiddot fluiddot mentioned this pull request Feb 2, 2021
3 tasks done
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants