Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Add support for "multiple": false block types - #3042

Merged
AmandaRiu merged 4 commits into
developfrom
fix/1156-more-block
Jan 26, 2021
Merged

AmandaRiu merged 4 commits into
developfrom
fix/1156-more-block

Conversation

@AmandaRiu

@AmandaRiu AmandaRiu commented Jan 22, 2021 •

Copy link
Copy Markdown
Contributor

Fixes #1156

Related PR

gutenberg: WordPress/gutenberg#28339

Steps to test

  1. Open the demo app on either android or ios. The demo already has a More block added to the post.
  2. Tap + to open the block menu - notice the More block is disabled. Verify tapping the More option does not work.
  3. Cancel the block menu.
  4. Delete the More block in the post.
  5. Tap + to open the block menu - notice the More block is now enabled. Tap to add this block to the post. Verify success.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Jan 22, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell cameronvoell added this to the 1.46 (16.7) milestone Jan 22, 2021

@cameronvoell cameronvoell left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved via WordPress/gutenberg#28339 (review)

After the linked gutenberg PR is merged, I think we can update the reference on this PR to the merged commit on gutenberg master and this PR will be ready to go. nice work!

@AmandaRiu

AmandaRiu commented Jan 26, 2021 •

Copy link
Copy Markdown
Contributor Author

@cameronvoell Updated the gutenberg reference and reverted changes to .submodules. Ready for final review 👍

@cameronvoell

cameronvoell commented Jan 26, 2021 •

Copy link
Copy Markdown
Contributor

Release notes update looks good, and great fix! 👍 :shipit:

@AmandaRiu
AmandaRiu merged commit 73ec0c7 into develop Jan 26, 2021
@AmandaRiu
AmandaRiu deleted the fix/1156-more-block branch January 26, 2021 20:17
@fluiddot fluiddot mentioned this pull request Feb 1, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read More Block: Don't allow multiple

2 participants