Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Persist keyboard as you switch from one block to another - #296

Merged
koke merged 4 commits into
masterfrom
issue/291-touchable-feedback
Nov 29, 2018
Merged

koke merged 4 commits into
masterfrom
issue/291-touchable-feedback

Conversation

@koke

@koke koke commented Nov 29, 2018

Copy link
Copy Markdown
Member

Another take at #291. Most of the changes are in wordpress-mobile/react-native-aztec#84 but this also sets keyboardShouldPersistTaps to always in the FlatList.

The default behavior had FlatList blurring field every time you tapped outside them, which meant they were being blurred twice and losing the keyboard.

To test, follow the steps in #291, and confirm the keyboard stays up. A known issue is that if you tap on a non-text block (image, unsupported), the current text field will keep focus, but that's a different task in #197

koke added 3 commits November 29, 2018 11:02
The default behavior had FlatList blurring field every time you tapped outside
them, which meant they were being blurred twice and losing the keyboard.

@mzorz mzorz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, found minor glitches that I'll document separately.
LGTM :shipit:

@koke
koke merged commit f4ade89 into master Nov 29, 2018
@koke
koke deleted the issue/291-touchable-feedback branch November 29, 2018 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants