Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Reusable blocks - Present block content (preview mode) - #2953

Merged
fluiddot merged 4 commits into
developfrom
2575-support-reusable-blocks
Jan 21, 2021
Merged

fluiddot merged 4 commits into
developfrom
2575-support-reusable-blocks

Conversation

@fluiddot

@fluiddot fluiddot commented Jan 4, 2021

Copy link
Copy Markdown
Contributor

Gutenberg PR -> WordPress/gutenberg#25265

Second part (adding Reusable blocks to the inserter menu):
Gutenberg PR -> WordPress/gutenberg#25383
Gutenberg-mobile PR -> #2644

Related to #2575

This PR is the first part of the issue Add Support to Insert Existing Reusable Blocks from the Editor.

The scope of this issue is limited to add Reusable blocks to the inserter menu, however due to the need of registering the Reusable block type (core/block), I also had to add support for presenting it in the editor.

The edition support will be added in this issue, so for now this PR only provides the preview mode of this type of block.

To test:
Check test steps in Gutenberg PR WordPress/gutenberg#25265

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Enhancement Improves a current area of the editor Blocks labels Jan 4, 2021
@fluiddot
fluiddot force-pushed the 2575-support-reusable-blocks branch from 08354b8 to e3fd9be Compare January 4, 2021 11:18
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Jan 4, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot

fluiddot commented Jan 4, 2021 •

Copy link
Copy Markdown
Contributor Author

Check correctness is also failing in the Dependabot's PR for bumping Gutengerg.

@fluiddot fluiddot mentioned this pull request Jan 6, 2021
2 tasks done
@fluiddot
fluiddot requested review from dcalhoun and guarani January 7, 2021 08:42
@fluiddot
fluiddot force-pushed the 2575-support-reusable-blocks branch 3 times, most recently from a95092a to 8f44856 Compare January 8, 2021 17:48
@guarani
guarani removed their request for review January 9, 2021 00:57
@guarani

guarani commented Jan 9, 2021

Copy link
Copy Markdown
Contributor

Just removing myself as reviewer since I won't be around for the next two weeks.

@fluiddot
fluiddot force-pushed the 2575-support-reusable-blocks branch from 8f44856 to 4a002f2 Compare January 13, 2021 08:34
@fluiddot fluiddot mentioned this pull request Jan 14, 2021
16 of 42 tasks
@fluiddot
fluiddot requested review from ceyhun and removed request for dcalhoun January 15, 2021 11:00

@ceyhun ceyhun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed via: WordPress/gutenberg#25265. We can merge this after the gutenberg PR is merged and the ref is updated.

@fluiddot
fluiddot force-pushed the 2575-support-reusable-blocks branch from 848fba1 to 5b392cd Compare January 19, 2021 12:54
@fluiddot fluiddot changed the title Add support Reusable blocks Reusable blocks - Present block content (preview mode) Jan 19, 2021
@fluiddot

Copy link
Copy Markdown
Contributor Author

Gutenberg submodule updated, now it's pointing to the merge commit of the Gutenberg PR in master.

@fluiddot fluiddot added this to the 1.46 (16.7) milestone Jan 21, 2021
@fluiddot
fluiddot merged commit ab7e9a6 into develop Jan 21, 2021
@fluiddot
fluiddot deleted the 2575-support-reusable-blocks branch January 21, 2021 11:01
@fluiddot fluiddot mentioned this pull request Feb 1, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Blocks [Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants