Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

[RNMobile] Using deferredEventEmitter to wait for the Editor to be mounted before issuing replaceBlock signal - #2949

Merged
mzorz merged 11 commits into
developfrom
rnmobile/stories-bridge-deferred-event
Feb 5, 2021
Merged

mzorz merged 11 commits into
developfrom
rnmobile/stories-bridge-deferred-event

Conversation

@mzorz

@mzorz mzorz commented Dec 31, 2020 •

Copy link
Copy Markdown
Contributor

Gutenberg PR WordPress/gutenberg#27944
Jetpack PR Automattic/jetpack#18540
WPAndroid PR wordpress-mobile/WordPress-Android#13699
Related stories library PR Automattic/stories-android#632

To test:
see wordpress-mobile/WordPress-Android#13699

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

…hanges and jetpack Story block with blockEditingId temporary setting
@peril-wordpress-mobile

peril-wordpress-mobile Bot commented Jan 17, 2021 •

Copy link
Copy Markdown

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@mzorz
mzorz requested a review from jd-alexander January 26, 2021 00:05
@guarani
guarani self-requested a review February 5, 2021 18:14

@guarani guarani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since @mzorz indicated that this is approved by @jd-alexander but lacking an approval.

@mzorz
mzorz merged commit 345c098 into develop Feb 5, 2021
@mzorz
mzorz deleted the rnmobile/stories-bridge-deferred-event branch February 5, 2021 18:15
@fluiddot fluiddot added this to the 1.46.1 (16.7) milestone Feb 12, 2021
@fluiddot

fluiddot commented Feb 15, 2021 •

Copy link
Copy Markdown
Contributor

👋 I'm moving this to 1.46.1 milestone because it's going to be included in the beta fix.

@mzorz

mzorz commented Feb 15, 2021

Copy link
Copy Markdown
Contributor Author

I'm moving this to 1.46.1 milestone because it's going to be included in the beta fix.

No concerns! thanks a lot @fluiddot 🙇

@fluiddot fluiddot mentioned this pull request Feb 15, 2021
3 tasks done
@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants