Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Issue/update aztec ios to 1.19.0 - #2226

Merged
SergioEstevao merged 4 commits into
developfrom
issue/update_aztec_ios_to_1.19.0
May 7, 2020
Merged

SergioEstevao merged 4 commits into
developfrom
issue/update_aztec_ios_to_1.19.0

Conversation

@SergioEstevao

Copy link
Copy Markdown
Contributor

Updates Aztec to version 1.19.0

To test:

  • Smoke test the demo app, especially the text blocks
  • Check the initial content block that has the sup and sub and see if it renders correctly.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added the [Type] Enhancement Improves a current area of the editor label May 6, 2020
@SergioEstevao SergioEstevao added this to the 1.28 milestone May 6, 2020
@SergioEstevao
SergioEstevao requested review from ceyhun and etoledom May 6, 2020 16:31

@etoledom etoledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @SergioEstevao for this PR!

I found two details:

Running pod install locally gives this diff:

     - React
-  - react-native-video (5.0.2):
+  - react-native-video (5.0.1):
     - React
-    - react-native-video/Video (= 5.0.2)
-  - react-native-video/Video (5.0.2):
+    - react-native-video/Video (= 5.0.1)
+  - react-native-video/Video (5.0.1):

I tried removing the Pods folder to be sure, and the diff appeared again. I wasn't sure since it's a version downgrade.

The other is something I didn't noticed in the Aztec PR, and I'm not sure if it's expected or not:
When I try to modify text before the subscript (or superscript) that text will be add as part of the subscript.

subscript

@SergioEstevao

Copy link
Copy Markdown
Contributor Author

The other is something I didn't noticed in the Aztec PR, and I'm not sure if it's expected or not:
When I try to modify text before the subscript (or superscript) that text will be add as part of the subscript.

That is expected it should work the same way as bold, italic, strikethrough.

@SergioEstevao

Copy link
Copy Markdown
Contributor Author

@etoledom I don't see the issue with the podfile in my machine, can you try to run yarn install before the pod install?

the video library was updated recently so you may have missed that update.

@etoledom etoledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you try to run yarn install before the pod install?

You are completely right! 🙏
Let's merge!

@etoledom etoledom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@SergioEstevao
SergioEstevao merged commit 2771be0 into develop May 7, 2020
@SergioEstevao
SergioEstevao deleted the issue/update_aztec_ios_to_1.19.0 branch May 7, 2020 17:44
@mchowning mchowning mentioned this pull request May 11, 2020
5 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Enhancement Improves a current area of the editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants