Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Color Settings - #2096

Merged
lukewalczak merged 6 commits into
developfrom
color-picker
May 5, 2020
Merged

lukewalczak merged 6 commits into
developfrom
color-picker

Conversation

@lukewalczak

@lukewalczak lukewalczak commented Apr 1, 2020 •

Copy link
Copy Markdown
Contributor

Fixes #1692

Ref to testing wp-ios: wordpress-mobile/WordPress-iOS#13690
Ref to testing wp-android: wordpress-mobile/WordPress-Android#11571
Ref to gutenberg: WordPress/gutenberg#21326

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak
lukewalczak force-pushed the color-picker branch 2 times, most recently from 42d2e42 to 546ff10 Compare April 2, 2020 17:11
@pinarol

pinarol commented Apr 13, 2020 •

Copy link
Copy Markdown
Contributor

Is this ready to code review?

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved via WordPress/gutenberg#21326 (review)

Let's not forget to remove the bundles, etc. Nice work! 🎉 👏

Comment thread RELEASE-NOTES.txt Outdated
* Fix Quote block so it visually reflects selected alignment
* Fix bug where buttons in page templates were not rendering correctly on web
* New block: Pullquote
* Add support for changing background and text color in Buttons block

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this should go in 1.28.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:o thanks!

@geriux geriux added this to the 1.28 milestone May 5, 2020
@lukewalczak
lukewalczak merged commit 4ab7249 into develop May 5, 2020
@lukewalczak
lukewalczak deleted the color-picker branch May 5, 2020 13:54
@mchowning mchowning mentioned this pull request May 11, 2020
5 tasks done
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Color picker to be used in block settings

3 participants