This repository was archived by the owner on Jul 9, 2026. It is now read-only.
Repository navigation
[Media Edit Icon] Show the media edit icon only if the block is selected - #1841
Merged
leandroalonso merged 4 commits intoJan 31, 2020
Merged
leandroalonso merged 4 commits into
leandroalonso merged 4 commits into
Conversation
Points to a fork
Contributor
|
@leandroalonso can you please add to the description the associated Gutenberg PR? This will make it easier to check associated changes. Thanks. |
Contributor
Author
|
@SergioEstevao updated! Sorry about that. |
etoledom
approved these changes
Jan 30, 2020
etoledom
left a comment
Contributor
There was a problem hiding this comment.
Approved via WordPress/gutenberg#19961 (review)
Let's wait for @iamthomasbishop's opinion 👍
Thank you for this improvement! 🎉
6 tasks done
Contributor
|
Looks good! |
…_block_is_selected
leandroalonso
deleted the
issue/1583_only_show_media_edit_icon_when_block_is_selected
branch
January 31, 2020 14:14
This was referenced Feb 3, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gutenberg PR: WordPress/gutenberg#19961
To test
Screenshots
PR submission checklist:
RELEASE-NOTES.txtif necessary.