Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

[RNMobile] Shortcode block support - #1774

Merged
chipsnyder merged 11 commits into
wordpress-mobile:developfrom
chipsnyder:issue/690-shortcode
Jan 15, 2020
Merged

chipsnyder merged 11 commits into
wordpress-mobile:developfrom
chipsnyder:issue/690-shortcode

Conversation

@chipsnyder

@chipsnyder chipsnyder commented Jan 13, 2020 •

Copy link
Copy Markdown
Contributor

Fixes #690

Gutenberg PR -> WordPress/gutenberg#19534

To test: See Gutenberg PR

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder
chipsnyder requested a review from koke January 13, 2020 21:43
@chipsnyder
chipsnyder marked this pull request as ready for review January 15, 2020 17:03
@chipsnyder
chipsnyder merged commit 55bed0c into wordpress-mobile:develop Jan 15, 2020
@chipsnyder
chipsnyder deleted the issue/690-shortcode branch January 15, 2020 18:07
@chipsnyder

Copy link
Copy Markdown
Contributor Author

@iamthomasbishop When you get some time can we do a design review for this? I have some screenshots in the other PR WordPress/gutenberg#19534 if it helps.

If you have any design feedback I'll be happy to open another PR to address those :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shortcode block

2 participants