Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix app crash after block removal due to undo button pressing - #1701

Merged
geriux merged 13 commits into
developfrom
fix-undo-crash
Dec 26, 2019
Merged

geriux merged 13 commits into
developfrom
fix-undo-crash

Conversation

@lukewalczak

@lukewalczak lukewalczak commented Dec 19, 2019 •

Copy link
Copy Markdown
Contributor

Fixes #1699 & wordpress-mobile/WordPress-Android#10876

Ref to gutenberg repo: WordPress/gutenberg#19239
To test:

1.Open mobile app
2. Add a block
3.Press undo button
4. Add a new block - if app not crashing everything is good 👍

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@lukewalczak lukewalczak self-assigned this Dec 19, 2019
@geriux
geriux self-requested a review December 19, 2019 13:56

@geriux geriux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested it via WordPress/gutenberg#19239 (review)

Can you please reference the other issue in this PR as well? So we can keep track of it after we release this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App crash after block removal due to undo button pressing

3 participants