Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Basic template picker - #1576

Merged
koke merged 10 commits into
developfrom
add/spt-basic-template-picker
Dec 20, 2019
Merged

koke merged 10 commits into
developfrom
add/spt-basic-template-picker

Conversation

@koke

@koke koke commented Nov 13, 2019 •

Copy link
Copy Markdown
Member

See WordPress/gutenberg#18052 for description.

Fixes #1462 #1464 and partially addresses #1463

To test:

Launch the apps and ensure the template picker is shown only on empty pages and when metro is running (__DEV__ == true)

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@koke koke added this to the 1.18 milestone Nov 13, 2019
@koke
koke requested review from mkevins and pinarol November 13, 2019 17:37
@koke koke mentioned this pull request Nov 21, 2019
1 task done
@koke
koke marked this pull request as ready for review December 3, 2019 10:01

@mkevins mkevins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with the steps described. Everything works as expected. Nice work! LGTM

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Template picker is shown only on empty pages

@koke koke modified the milestones: 1.18, 1.20 Dec 16, 2019
@koke
koke merged commit 7de3ee5 into develop Dec 20, 2019
@koke
koke deleted the add/spt-basic-template-picker branch December 20, 2019 09:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create base set of page templates

3 participants