Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Nudge for adding tests, clearer language on the PR template - #1561

Merged
maxme merged 2 commits into
developfrom
update-pr-template
Dec 13, 2019
Merged

maxme merged 2 commits into
developfrom
update-pr-template

Conversation

@hypest

@hypest hypest commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

Updates the PR template to match the main WP apps:

  1. More clear language, indicating that the author needs to check the checkboxes
  2. Nudge for adding tests

Taken from https://github.com/wordpress-mobile/WordPress-Android/blob/db0bba0e3012be0a0533737ac054d74453e05a34/.github/PULL_REQUEST_TEMPLATE.md

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@hypest hypest added the Tooling label Nov 8, 2019
@hypest hypest added this to the 1.17 milestone Nov 8, 2019
@hypest
hypest requested a review from maxme November 8, 2019 14:46
@hypest hypest changed the title Nudge for addins tests, clearer language on the PR template Nudge for adding tests, clearer language on the PR template Nov 11, 2019
@hypest hypest modified the milestones: 1.17, 1.19 Nov 27, 2019

@maxme maxme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, :shipit:

@maxme
maxme merged commit 06b924d into develop Dec 13, 2019
@maxme
maxme deleted the update-pr-template branch December 13, 2019 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants