Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Image Block: Adding example block with image. - #143

Merged
etoledom merged 1 commit into
masterfrom
feature/image-block-vol-02
Sep 14, 2018
Merged

etoledom merged 1 commit into
masterfrom
feature/image-block-vol-02

Conversation

@etoledom

@etoledom etoledom commented Sep 13, 2018 •

Copy link
Copy Markdown
Contributor

Part of #140

This PR implements the changes on the Gutenberg project to display the content of an image block, or the empty block UI.

To be able to test them, this PR also adds an extra example block with an image to be displayed.

The buttons to add images do nothing. That's fine for now :)

image_block_with_image

To test:

  • Be sure that the Gutenberg submodule point to 06793a.
  • Run the project.
  • Check that the UI looks like in the screenshot.
  • Add a new image block.
  • Check that the empty image block was added.

@etoledom
etoledom requested a review from mzorz September 13, 2018 23:43
@etoledom etoledom self-assigned this Sep 13, 2018

@mzorz mzorz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm @etoledom ! tested, works exactly as advertised 🙌

@hypest

hypest commented Sep 14, 2018

Copy link
Copy Markdown
Contributor

The buttons to add images do nothing. That's fine for now :)

Heh, can anyone be super happy seeing unfinished functionality?! Well, I'm among those people ;)

Thanks for the nice execution of the "just focus on small steps" mentality @etoledom 🙇‍♂️

@etoledom
etoledom merged commit ebd45da into master Sep 14, 2018
@etoledom
etoledom deleted the feature/image-block-vol-02 branch September 14, 2018 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants