Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Most basic image block - #141

Merged
daniloercoli merged 7 commits into
masterfrom
feature/image-block
Sep 13, 2018
Merged

daniloercoli merged 7 commits into
masterfrom
feature/image-block

Conversation

@etoledom

@etoledom etoledom commented Sep 12, 2018 •

Copy link
Copy Markdown
Contributor

Parts of #140 .
This PR implements the changes on Gutenberg to recognize the image block.

image-block

To test:

  • Update the Gutenberg submodule (should be pointing to fc16864 )
  • yarn clean
  • yarn install
  • Check that the image placeholder is shown.

This solves a builder error when importing the image block from `block-library/src/image/edit.native.js`.
@daniloercoli
daniloercoli self-requested a review September 13, 2018 15:55
@daniloercoli

Copy link
Copy Markdown
Contributor

Looks good! :shipit:

@daniloercoli
daniloercoli merged commit e6d6ed9 into master Sep 13, 2018
@daniloercoli
daniloercoli deleted the feature/image-block branch September 13, 2018 16:01
@etoledom etoledom mentioned this pull request Sep 13, 2018
5 of 10 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants