Skip to content
This repository was archived by the owner on Jul 9, 2026. It is now read-only.

Fix keyboard hide button - #1340

Merged
pinarol merged 1 commit into
developfrom
issue/952-post-title-dismiss-keyboard
Aug 30, 2019
Merged

pinarol merged 1 commit into
developfrom
issue/952-post-title-dismiss-keyboard

Conversation

@geriux

@geriux geriux commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

Fixes #952

Full description of the fix is in the description of the related Gutenberg PR.

Update release notes:

There aren't any user-facing changes

@geriux geriux added the bugfix label Aug 30, 2019
@geriux geriux mentioned this pull request Aug 30, 2019
@geriux
geriux requested a review from pinarol August 30, 2019 09:23
@pinarol

pinarol commented Aug 30, 2019

Copy link
Copy Markdown
Contributor

Failing Android tests are a known issue, not related with this PR

I ran Android UI tests(yarn test:e2e:android:local) locally by updating __device-tests__/helpers/caps.js > deviceName: 'Pixel 2 XL API 28' since that's the one available in my local.

They look fine:

Test Suites: 8 passed, 8 total
Tests:       21 passed, 21 total
Snapshots:   0 total
Time:        488.747s, estimated 523s
Ran all test suites.
✨  Done in 549.28s.

@pinarol pinarol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pinarol
pinarol merged commit b8f30f7 into develop Aug 30, 2019
@pinarol
pinarol deleted the issue/952-post-title-dismiss-keyboard branch August 30, 2019 10:14
daniloercoli added a commit that referenced this pull request Sep 4, 2019
…rg-mobile into add/autosave-monitor

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (56 commits)
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Add support for group component (#1335)
  Update gutenberg hash
  fix error generating app name on sauce
  Bump eslint-utils from 1.3.1 to 1.4.2
  Update gutenberg ref
  Update release notes
  Update gutenberg ref to rnmobile/master HEAD
  disable paste tests
  MediaUpload and MediaPlaceholder unify props (#1310)
  Update gutenberg ref (#1340)
  Update gutenberg ref
  disable list tests and enable paste tests
  enable list tests
  enable list end tests
  enable block insertion tests
  enable heading tests
  ...

# Conflicts:
#	gutenberg
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS]Keyboard hide button is not working on post title

2 participants