Repository navigation
Fix support conversations that ask for a human in the first message - #26404
Merged
Merged
Conversation
Pins wordpress-rs to its trunk-build snapshot of 39cefd51, which reads a numeric zendesk_ticket_id when creating a support bot conversation. Comment author avatar URLs are now optional in wordpress-rs, so use optional chaining where the app reads them.
6 tasks done
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
trunk-build is force-pushed on every wordpress-rs trunk merge, so the previous commit is no longer on any branch and CI can't fetch it.
jkmassel
marked this pull request as ready for review
November 13, 2026 23:18
crazytonyli
requested changes
Nov 15, 2026
| .package( | ||
| url: "https://github.com/automattic/wordpress-rs", | ||
| exact: "0.9.1" | ||
| revision: "8e619ff1dfed123d9d321ac73285048fa9f627a4" |
Contributor
There was a problem hiding this comment.
This needs to be updated before merging.
0.11.0 is the first release with the support ticket ID fix, so pin to it instead of the trunk-build snapshot. Nothing else in the release needed changes in the app.
crazytonyli
approved these changes
Nov 18, 2026
This was referenced Nov 18, 2026
jkmassel
added a commit
that referenced
this pull request
Nov 18, 2026
wordpress-rs 0.11.0 (from #26404) is the first release with `ReaderSavedService`, which this branch used from PR builds. - `importSaves` replaces `importLocalSaves` and imports whenever it's asked, so the app records the launch import per account in `UserDefaults`, clears the record on sign-out, and runs one import at a time. - JSON import sends the file's posts in one `importSaves` call, with the file's title, excerpt, image and site, rather than one save per post. - A tap past the account's 1,000-save cap fails with `TooManySaves`, and the notice says the account is at its limit. A sync that leaves saves waiting for room logs it rather than warning. - `ReaderPost.tags` is optional. Core Data can't tell a post without tags from one whose tags it doesn't have, so it sends `nil` for none. - The store takes the notification center it observes, so parallel tests don't sync each other's stores.
jkmassel
added a commit
that referenced
this pull request
Nov 20, 2026
wordpress-rs 0.11.0 (from #26404) is the first release with `ReaderSavedService`, which this branch used from PR builds. - `importSaves` replaces `importLocalSaves` and imports whenever it's asked, so the app records the launch import per account in `UserDefaults`, clears the record on sign-out, and runs one import at a time. - JSON import sends the file's posts in one `importSaves` call, with the file's title, excerpt, image and site, rather than one save per post. - A tap past the account's 1,000-save cap fails with `TooManySaves`, and the notice says the account is at its limit. A sync that leaves saves waiting for room logs it rather than warning. - `ReaderPost.tags` is optional. Core Data can't tell a post without tags from one whose tags it doesn't have, so it sends `nil` for none. - The store takes the notification center it observes, so parallel tests don't sync each other's stores.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes "Response couldn't be parsed" when the first message of a new support conversation asks for a human. The server creates a Zendesk ticket and returns its ID as a number, which wordpress-rs expected as a string, so the app showed the error even though the ticket was created. Each retry created another ticket.
The fix is in wordpress-rs (Automattic/wordpress-rs#1744) and shipped in 0.11.0. This PR updates wordpress-rs from
0.9.1to0.11.0.Changes
0.9.1→0.11.0.authorAvatarUrlsis now optional in wordpress-rs, because WordPress omits it when a site turns off "Show Avatars". Use optional chaining; the avatar URL was already optional.None of the other breaking changes in
0.10.0and0.11.0(CloudflareError,menu_orderasInt64?, optionalWPComSitefields, the newReaderSavedPostshape) affected the app's build.What I ran
The whole
WordPressUnitTestsplan against0.11.0, withtrunk(67c9031f6b) merged in:4638 passed, 0 failed, 2 skipped, 1 expected failure(4641 tests), on an iPhone 18 Pro simulator (iOS 27.2).Testing instructions
Both checks were run on a Jetpack Debug build with wordpress-rs
0.11.0, on an iPhone 18 Pro simulator (iOS 27.2) with the New Support flag on.New conversation that asks for a human. Get help → New conversation → "From Claude app test please disregard I want to talk to a human". The conversation opened and the assistant said it opened a ticket; no parse error. On
trunk, the same message shows "Response couldn't be parsed: invalid type: integer…, expected a string".Reply with attachments to that conversation (a GIF and a video) sent and showed both. Replies use the unified support endpoint, which this PR doesn't change; checked because the wordpress-rs update touches it.