Repository navigation
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
Version |
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 20, 2026 23:13
64b1bf7 to
cae9472
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 20, 2026 23:13
e76a84b to
7368cb4
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 20, 2026 23:16
cae9472 to
c6e37c4
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 20, 2026 23:16
7368cb4 to
4562c88
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 20, 2026 23:50
c6e37c4 to
6936a94
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 20, 2026 23:50
4562c88 to
0e5e651
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 21, 2026 00:57
6936a94 to
84e921c
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 21, 2026 00:57
0e5e651 to
f2827fa
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 21, 2026 01:45
84e921c to
5624dfe
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
3 times, most recently
from
November 21, 2026 02:17
ed7c7d1 to
7fc2854
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 21, 2026 02:17
5624dfe to
2126741
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 21, 2026 02:58
7fc2854 to
3dd370f
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 21, 2026 02:58
2126741 to
3467180
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 21, 2026 04:17
fdaeac3 to
973fbdf
Compare
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 21, 2026 04:17
3467180 to
954dc97
Compare
7 tasks done
jkmassel
marked this pull request as ready for review
November 21, 2026 04:50
The site menu is a SwiftUI list since #26026. Its row identifiers are on buttons inside the cells, or on an iPad, where the menu is a sidebar, on static texts. The Staff row has no identifier of its own, so it's found by its title. Each row is tapped until its screen appears: just after a launch, an iPad's site menu can ignore a tap while the app restores the screen it last showed.
Since #26398 the WordPress app shows the Reader and Notifications, so the comment no longer explains why its screenshots show what they do.
On CI, the first tap on the draft sometimes didn't open the editor: 3 of 108 jobs in the last two full runs, each passing on Buildkite's retry. The recordings show the drafts list unchanged after the tap, while the draft's row redraws as its thumbnail loads.
jkmassel
force-pushed
the
jkmassel/app-store-screenshots
branch
from
November 21, 2026 05:09
954dc97 to
0493336
Compare
jkmassel
force-pushed
the
jkmassel/wordpress-app-store-screenshots
branch
from
November 21, 2026 05:09
973fbdf to
71e24cc
Compare
The WordPress app now shows the Reader to WordPress.com accounts (#26398), so its screenshots show it too, as the fifth: the same Reader post the Jetpack screenshots open. The WordPress screenshots' fixtures turn on the wordpress_ios_reader flag, which the UI tests' fixtures leave off; without it the app shows its Jetpack poster in the Reader tab. The headline reuses the Jetpack Reader headline and its translations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates the WordPress app's App Store screenshots from the app, the same way #26339 does for Jetpack: the same UI test, fixtures, devices and compositor, in every App Store language, on iPhone, iPad and both iPhone Duo displays.
Stacked on #26339.
Summary
bundle exec fastlane wordpress_screenshotsbuilds the WordPress app with the fixtures and runs theAppStoreScreenshotstest against it. The test target is still Jetpack's; it launches the WordPress app by its bundle identifier.bundle exec fastlane create_promo_screenshotsnow composes them withScripts/app-store-screenshots/compose.swift, with the WordPress logo on the title screen. It replaces the release toolkit'spromo_screenshotslayout.bundle exec fastlane trigger_app_store_screenshots app:wordpress(orapp:jetpack) runs the screenshot pipeline on CI for either app. It replacestrigger_jetpack_screenshots.fastlane/appstoreres/screenshot_fixtures/wordpress/, loaded over the UI tests' fixtures. They make the fixture site an Atomic site, since the app only shows custom post types on sites it reaches through the core REST API, and give it a Staff post type with four agents. They also turn on the app's Reader flag (wordpress_ios_reader), which the UI tests' fixtures leave off; without it the Reader tab shows the Jetpack poster. The UI tests don't see any of it.fastlane/screenshots.json), its assets, and itsapp_store_screenshot_*headlines.fastlane/appstoreres/jetpack_screenshot_content/is nowscreenshot_content/, shared by both apps.App changes
Both only apply to builds for the UI tests.
Library/app.sqlite). A sync only fetches what changed on the server, so a cache left from an earlier launch kept showing what that launch was sent.-ui-test-app-store-screenshotshides the beta badge on the custom post types screen.CI fixes
These came out of the full CI runs, and apply to both apps:
env:doesn't reach the Mac VMs..xcresult, which includes a screen recording.Screenshots
From CI build #36369. Each image is one language and device side by side, as the compose step writes them.
English
Japanese and Arabic
Test plan
xcodebuildhung relaunching the app.Not in this PR
retropatterns for now.