Skip to content

Generate the WordPress App Store screenshots from the app - #26355

Open
jkmassel wants to merge 17 commits into
jkmassel/app-store-screenshotsfrom
jkmassel/wordpress-app-store-screenshots
Open

jkmassel wants to merge 17 commits into
jkmassel/app-store-screenshotsfrom
jkmassel/wordpress-app-store-screenshots

Conversation

@jkmassel

@jkmassel jkmassel commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Generates the WordPress app's App Store screenshots from the app, the same way #26339 does for Jetpack: the same UI test, fixtures, devices and compositor, in every App Store language, on iPhone, iPad and both iPhone Duo displays.

Stacked on #26339.

Summary

  • Screens: Editor, Staff (a custom post type), Media, Pages and the Reader. The Reader is the same post the Jetpack screenshots open, since the WordPress app now shows the Reader to WordPress.com accounts (Show Reader in the first session after signing in to the WordPress app #26398).
  • bundle exec fastlane wordpress_screenshots builds the WordPress app with the fixtures and runs the AppStoreScreenshots test against it. The test target is still Jetpack's; it launches the WordPress app by its bundle identifier.
  • bundle exec fastlane create_promo_screenshots now composes them with Scripts/app-store-screenshots/compose.swift, with the WordPress logo on the title screen. It replaces the release toolkit's promo_screenshots layout.
  • bundle exec fastlane trigger_app_store_screenshots app:wordpress (or app:jetpack) runs the screenshot pipeline on CI for either app. It replaces trigger_jetpack_screenshots.
  • The WordPress screenshots have fixtures of their own, in fastlane/appstoreres/screenshot_fixtures/wordpress/, loaded over the UI tests' fixtures. They make the fixture site an Atomic site, since the app only shows custom post types on sites it reaches through the core REST API, and give it a Staff post type with four agents. They also turn on the app's Reader flag (wordpress_ios_reader), which the UI tests' fixtures leave off; without it the Reader tab shows the Jetpack poster. The UI tests don't see any of it.
  • The headlines are new GlotPress strings, a feature name and the rest, as for Jetpack. The title, Editor, Media and Pages headlines reuse the translators' wording of the old WordPress screenshots where it fits, and the Reader headline reuses the Jetpack one and its translations.
  • Removed: the old WordPress screenshot layout (fastlane/screenshots.json), its assets, and its app_store_screenshot_* headlines.
  • fastlane/appstoreres/jetpack_screenshot_content/ is now screenshot_content/, shared by both apps.

App changes

Both only apply to builds for the UI tests.

  • A UI test reset now clears the wordpress-rs cache (Library/app.sqlite). A sync only fetches what changed on the server, so a cache left from an earlier launch kept showing what that launch was sent.
  • -ui-test-app-store-screenshots hides the beta badge on the custom post types screen.

CI fixes

These came out of the full CI runs, and apply to both apps:

  • The app is passed to each screenshot job as a command argument. A step's env: doesn't reach the Mac VMs.
  • The Duo inner display is retried. The app sometimes never moved onto it, leaving a black screenshot. The lane now waits for the right size and retries the resize up to three times.
  • The compositor rejects screenshots of an unknown size. It used to treat one as an iPad screenshot and overwrite the real iPad files.
  • The screenshot build is set up like trunk's build for testing (secrets and Swift package cache).
  • The test is sturdier in other languages and on iPad: it finds a notification by the commenter's name wherever the language puts it (Arabic puts the verb first), relaunches after the editor screenshot instead of closing the editor, and starts the WordPress iPad screenshots from the site menu, since there's no Home there.
  • Failed jobs upload their .xcresult, which includes a screen recording.
  • The test taps the draft until the editor opens. The drafts list can redraw the draft's row as its thumbnail loads, and a tap at that moment is dropped.
  • The test opens the site menu's rows by identifier, and taps each until its screen opens. The site menu is a SwiftUI list since Render blog details with a native SwiftUI list #26026: a row's identifier is on a button, or on an iPad on a static text. Just after a launch, an iPad's site menu can ignore a tap while the app restores the screen it last showed.

Screenshots

From CI build #36369. Each image is one language and device side by side, as the compose step writes them.

English

English, iPhone: title screen, Editor, Staff, Media, Pages and Reader

English, iPad: title screen, Editor, Staff, Media, Pages and Reader

English, iPhone Duo inner display

English, iPhone Duo outer display

Japanese and Arabic

Japanese, iPhone, with translated content

Arabic, iPhone, right to left, with translated content

Test plan

  • Full WordPress screenshot run on CI on this branch: #36369. All 54 jobs passed on their first attempt, and every language has all five screenshots on every device.
  • Full Jetpack screenshot run on CI on this branch, since its Reader steps moved into a helper the WordPress flow shares: #36370. All 54 jobs passed on their first attempt.
  • The draft opens reliably. Before the test retried the tap on it, the editor didn't open in 3 of 108 jobs. In four full runs before the Reader was added (#36363, #36364, #36365, #36366), 216 jobs, it never failed. One job there, iPhone Duo in Hebrew, passed on Buildkite's automatic retry after xcodebuild hung relaunching the app.
  • Locally, with Xcode 27.1: the WordPress screenshots, Reader included, passed on iPhone in English, on iPad in English and Arabic (the sidebar is on the right), and on the iPhone Duo in English and Japanese.
  • Checked the composed overviews for English iPhone, iPad and both Duo displays, Japanese and Arabic. The Reader shows the translated post, and its headline fits in two lines.

Not in this PR

  • Uploading the screenshots to App Store Connect.
  • Putting the headlines and on-screen content through the translation pipeline. Like Generate the Jetpack App Store screenshots from the app #26339's, the translations are temporary, by Claude.
  • Real headshots for the Staff agents. They're Gravatar's generated retro patterns for now.
  • The iPad status bar shows the date and the app's name next to the time. That's iPadOS 26 behaviour.

@jkmassel jkmassel added this to the 27.5 milestone Nov 6, 2026
@jkmassel jkmassel added Testing Unit and UI Tests and Tooling Tooling Build, Release, and Validation Tools labels Nov 6, 2026
@jkmassel jkmassel self-assigned this Nov 6, 2026
@dangermattic

dangermattic commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

@wpmobilebot wpmobilebot modified the milestones: 27.5, 27.6 Nov 20, 2026
@wpmobilebot

Copy link
Copy Markdown
Contributor

Version 27.5 has now entered code-freeze, so the milestone of this PR has been updated to 27.6.

@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 64b1bf7 to cae9472 Compare November 20, 2026 23:13
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from e76a84b to 7368cb4 Compare November 20, 2026 23:13
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from cae9472 to c6e37c4 Compare November 20, 2026 23:16
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from 7368cb4 to 4562c88 Compare November 20, 2026 23:16
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from c6e37c4 to 6936a94 Compare November 20, 2026 23:50
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from 4562c88 to 0e5e651 Compare November 20, 2026 23:50
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 6936a94 to 84e921c Compare November 21, 2026 00:57
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from 0e5e651 to f2827fa Compare November 21, 2026 00:57
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 84e921c to 5624dfe Compare November 21, 2026 01:45
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch 3 times, most recently from ed7c7d1 to 7fc2854 Compare November 21, 2026 02:17
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 5624dfe to 2126741 Compare November 21, 2026 02:17
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from 7fc2854 to 3dd370f Compare November 21, 2026 02:58
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 2126741 to 3467180 Compare November 21, 2026 02:58
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from fdaeac3 to 973fbdf Compare November 21, 2026 04:17
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 3467180 to 954dc97 Compare November 21, 2026 04:17
@jkmassel
jkmassel marked this pull request as ready for review November 21, 2026 04:50
@jkmassel
jkmassel requested a review from a team as a code owner November 21, 2026 04:50
@jkmassel
jkmassel requested a review from crazytonyli November 21, 2026 04:50
The site menu is a SwiftUI list since #26026. Its row identifiers are
on buttons inside the cells, or on an iPad, where the menu is a
sidebar, on static texts. The Staff row has no identifier of its own,
so it's found by its title.

Each row is tapped until its screen appears: just after a launch, an
iPad's site menu can ignore a tap while the app restores the screen it
last showed.
Since #26398 the WordPress app shows the Reader and Notifications, so
the comment no longer explains why its screenshots show what they do.
On CI, the first tap on the draft sometimes didn't open the editor:
3 of 108 jobs in the last two full runs, each passing on Buildkite's
retry. The recordings show the drafts list unchanged after the tap,
while the draft's row redraws as its thumbnail loads.
@jkmassel
jkmassel force-pushed the jkmassel/app-store-screenshots branch from 954dc97 to 0493336 Compare November 21, 2026 05:09
@jkmassel
jkmassel force-pushed the jkmassel/wordpress-app-store-screenshots branch from 973fbdf to 71e24cc Compare November 21, 2026 05:09
The WordPress app now shows the Reader to WordPress.com accounts
(#26398), so its screenshots show it too, as the fifth: the same
Reader post the Jetpack screenshots open.

The WordPress screenshots' fixtures turn on the wordpress_ios_reader
flag, which the UI tests' fixtures leave off; without it the app shows
its Jetpack poster in the Reader tab. The headline reuses the Jetpack
Reader headline and its translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Unit and UI Tests and Tooling Tooling Build, Release, and Validation Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants