Repository navigation
Conversation
This was referenced Oct 24, 2026
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 35270 | |
| Version | PR #26216 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c2aaff4 | |
| Installation URL | 4pl8n3f8ejn8g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 35270 | |
| Version | PR #26216 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c2aaff4 | |
| Installation URL | 7qop3mrkpsj3g |
This was referenced Oct 25, 2026
jkmassel
force-pushed
the
jkmassel/duo-no-sites-account-button
branch
from
October 26, 2026 18:54
2bdfe15 to
72233e9
Compare
jkmassel
marked this pull request as ready for review
October 26, 2026 19:39
Contributor
|
This PR would have conflict with #26215 |
In the WordPress app's reduced layout there is no Me tab, and someone with no sites reaches their account through the "Account and settings" button. It was only shown at compact width, so on a regular-width iPhone screen there was no way to reach account settings or sign out. Hide it only on iPad at regular width, where the sidebar links to the account.
Ask the split view whether it's collapsed instead of adding an `isPad()` check, matching the notification and My Site screens. `NoSitesView` can't read it, so a small hosting controller sets `isInExpandedSplitView` when the view appears and on layout. A trait change callback runs before the split view collapses or expands, so it would still see the old value.
jkmassel
force-pushed
the
jkmassel/duo-no-sites-account-button
branch
from
October 27, 2026 09:42
72233e9 to
c2aaff4
Compare
Contributor
Author
Should be sorted now, thanks! |
crazytonyli
approved these changes
Oct 27, 2026
Contributor
|
I feel like there is other issue here. I think the tab bar should show up on regular width iPhone, like the iPhone 18 Pro landscape screenshot. |
1 task done
Contributor
|
Version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes the WordPress app hiding the "Account and settings" button on the no-sites screen on wide iPhone screens, which left no way to reach account settings or sign out.
One of ten fixes for wide and folding iPhone screens, together with #26207, #26208, #26209, #26210, #26211, #26212, #26213, #26214, #26215. None depends on another, so they can merge in any order.
Root cause
The WordPress app's reduced layout has no tab bar. Someone signed in there with no sites reaches their account through the "Account and settings" button on
NoSitesView. The button is only shown at a compact width, on the assumption that a regular width means an iPad, where the sidebar links to the account. On the iPhone Duo's inner screen and on Plus and Pro Max models in landscape, there's no sidebar.Fix
Hide the button only in an expanded split view, by asking the split view whether it's collapsed (
splitViewController?.isCollapsed), the same check #26215 uses:NoSitesView.swift: the SwiftUI view can't ask the split view, so a newNoSitesHostingControllersetsisInExpandedSplitViewwhen the view appears and on layout. A size-class change callback runs before the split view collapses or expands, so it would still see the oldisCollapsed. Both places that showNoSitesViewuse it.iPad behaviour is unchanged: on iPad the no-sites view is the split view's detail column, whose size class matches the split view's.
Screenshots
iPhone 18 Pro Max in landscape, WordPress app, signed in with no sites:
iPad, WordPress app, signed in with no sites (trunk looks the same in both):
The account has sites, so every build had a temporary local change that hid them from My Site (not committed). The reduced layout was forced with
"-ff-override-Jetpack Features Removal Phase Four" YES.Test plan
NoSitesHostingControllerTests: the button shows without a split view at either width, hides in an expanded split view, and comes back when the split view collapses.c2aaff48e6): same results, and the screenshots above are unchanged.